Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 22b3f4cb authored by Billy Lau's avatar Billy Lau
Browse files

Bug: 21589105 Rescope WRITE_SETTINGS and SYSTEM_ALERT_WINDOW permission 

Raised the protection level of WRITE_SETTINGS permission to appop and also
allowed backwards compatibility with pre23 flag. Also made sure that this
permission is not added as RuntimePermission in DefaultPermissionGrantPolicy as
that breaks a lot of gmscore stuff.

Introduced new action to manage write system settings as a new API and
renamed the string that describes the managing of overlay permission.

Change-Id: Ifd25a6ddc06de68ee37015cb9fb23452e4ef10f4
parent 4ccf69e1

api/current.txt

+2 −1
Original line number Diff line number Diff line
@@ -26405,7 +26405,8 @@ package android.provider { 
    field public static final java.lang.String ACTION_LOCATION_SOURCE_SETTINGS = "android.settings.LOCATION_SOURCE_SETTINGS";

    field public static final java.lang.String ACTION_MANAGE_ALL_APPLICATIONS_SETTINGS = "android.settings.MANAGE_ALL_APPLICATIONS_SETTINGS";

    field public static final java.lang.String ACTION_MANAGE_APPLICATIONS_SETTINGS = "android.settings.MANAGE_APPLICATIONS_SETTINGS";

    field public static final java.lang.String ACTION_MANAGE_OVERLAY_PERMISSION = "android.settings.MANAGE_OVERLAY_PERMISSION";

    field public static final java.lang.String ACTION_MANAGE_OVERLAY_PERMISSION = "android.settings.action.MANAGE_OVERLAY_PERMISSION";

    field public static final java.lang.String ACTION_MANAGE_WRITE_SETTINGS = "android.settings.action.MANAGE_WRITE_SETTINGS";

    field public static final java.lang.String ACTION_MEMORY_CARD_SETTINGS = "android.settings.MEMORY_CARD_SETTINGS";

    field public static final java.lang.String ACTION_NETWORK_OPERATOR_SETTINGS = "android.settings.NETWORK_OPERATOR_SETTINGS";

    field public static final java.lang.String ACTION_NFCSHARING_SETTINGS = "android.settings.NFCSHARING_SETTINGS";

api/system-current.txt

+2 −1
Original line number Diff line number Diff line
@@ -28461,7 +28461,8 @@ package android.provider { 
    field public static final java.lang.String ACTION_LOCATION_SOURCE_SETTINGS = "android.settings.LOCATION_SOURCE_SETTINGS";

    field public static final java.lang.String ACTION_MANAGE_ALL_APPLICATIONS_SETTINGS = "android.settings.MANAGE_ALL_APPLICATIONS_SETTINGS";

    field public static final java.lang.String ACTION_MANAGE_APPLICATIONS_SETTINGS = "android.settings.MANAGE_APPLICATIONS_SETTINGS";

    field public static final java.lang.String ACTION_MANAGE_OVERLAY_PERMISSION = "android.settings.MANAGE_OVERLAY_PERMISSION";

    field public static final java.lang.String ACTION_MANAGE_OVERLAY_PERMISSION = "android.settings.action.MANAGE_OVERLAY_PERMISSION";

    field public static final java.lang.String ACTION_MANAGE_WRITE_SETTINGS = "android.settings.action.MANAGE_WRITE_SETTINGS";

    field public static final java.lang.String ACTION_MEMORY_CARD_SETTINGS = "android.settings.MEMORY_CARD_SETTINGS";

    field public static final java.lang.String ACTION_NETWORK_OPERATOR_SETTINGS = "android.settings.NETWORK_OPERATOR_SETTINGS";

    field public static final java.lang.String ACTION_NFCSHARING_SETTINGS = "android.settings.NFCSHARING_SETTINGS";

core/java/android/provider/Settings.java

+16 −1
Original line number Diff line number Diff line
@@ -574,7 +574,22 @@ public final class Settings { 
     */

    @SdkConstant(SdkConstantType.ACTIVITY_INTENT_ACTION)

    public static final String ACTION_MANAGE_OVERLAY_PERMISSION =

            "android.settings.MANAGE_OVERLAY_PERMISSION";

            "android.settings.action.MANAGE_OVERLAY_PERMISSION";



    /**

     * Activity Action: Show settings to toggle apps' capablity to

     * to read/write system settings.

     * <p>

     * In some cases, a matching Activity may not exist, so ensure you

     * safeguard against this.

     * <p>

     * Input: Nothing.

     * <p>

     * Output: Nothing.

     */

    @SdkConstant(SdkConstantType.ACTIVITY_INTENT_ACTION)

    public static final String ACTION_MANAGE_WRITE_SETTINGS =

            "android.settings.action.MANAGE_WRITE_SETTINGS";



    /**

     * Activity Action: Show screen of details about a particular application.

core/res/AndroidManifest.xml

+1 −1
Original line number Diff line number Diff line
@@ -1538,7 +1538,7 @@ 
    <permission android:name="android.permission.WRITE_SETTINGS"

        android:label="@string/permlab_writeSettings"

        android:description="@string/permdesc_writeSettings"

        android:protectionLevel="dangerous" />

        android:protectionLevel="signature|preinstalled|appop|pre23" />



    <!-- @SystemApi Allows an application to modify the Google service map.

    <p>Not for use by third-party applications. -->

services/core/java/com/android/server/pm/DefaultPermissionGrantPolicy.java

+0 −1
Original line number Diff line number Diff line
@@ -261,7 +261,6 @@ final class DefaultPermissionGrantPolicy { 
                    && doesPackageSupportRuntimePermissions(setupPackage)) {

                grantRuntimePermissionsLPw(setupPackage, PHONE_PERMISSIONS, userId);

                grantRuntimePermissionsLPw(setupPackage, CONTACTS_PERMISSIONS, userId);

                grantRuntimePermissionsLPw(setupPackage, SETTINGS_PERMISSIONS, userId);

            }



            // Camera