Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 229cad0a authored by ywen's avatar ywen Committed by Digish Pandya
Browse files

Performance Optimization: Align texture dirty rect 

Align x offset and width to 32, y offset and height to 4.
It improves the font texture upload performance.

Change-Id: I967eeed90658f2ce1eb08cb2740d5dc34c72f40b
parent 1818ef08

libs/hwui/font/CacheTexture.cpp

+10 −4
Original line number Diff line number Diff line
@@ -204,15 +204,21 @@ void CacheTexture::allocatePixelBuffer() { 
bool CacheTexture::upload() {

    const Rect& dirtyRect = mDirtyRect;



    uint32_t x = mHasUnpackRowLength ? dirtyRect.left : 0;

    uint32_t y = dirtyRect.top;

    uint32_t width = mHasUnpackRowLength ? dirtyRect.getWidth() : getWidth();

    uint32_t height = dirtyRect.getHeight();

    // align the x direction to 32 and y direction to 4 for better performance

    uint32_t x = (((uint32_t)dirtyRect.left) & (~0x1F));

    uint32_t y = (((uint32_t)dirtyRect.top) & (~0x3));

    uint32_t r = ((((uint32_t)dirtyRect.right) + 0x1F) & (~0x1F)) - x;

    uint32_t b = ((((uint32_t)dirtyRect.bottom) + 0x3) & (~0x3)) - y;

    uint32_t width = (r > getWidth() ? getWidth() : r);

    uint32_t height = (b > getHeight() ? getHeight() : b);



    // The unpack row length only needs to be specified when a new

    // texture is bound

    if (mHasUnpackRowLength) {

        glPixelStorei(GL_UNPACK_ROW_LENGTH, getWidth());

    } else {

        x = 0;

        width = getWidth();

    }



    mPixelBuffer->upload(x, y, width, height);