Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 226fa7d3 authored by William Loh's avatar William Loh Committed by Automerger Merge Worker
Browse files

Limit length and number of MIME types you can set am: 9bdd9d27 am: b7701b14 

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19539263



Change-Id: Ia2b3d8c14c2246f06c4ba8253edfb0af72a36c0b
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents b5d33bd8 b7701b14

services/core/java/com/android/server/pm/PackageManagerService.java

+9 −0
Original line number Diff line number Diff line
@@ -5797,6 +5797,11 @@ public class PackageManagerService implements PackageSender, TestUtilityService 
            final Computer snapshot = snapshotComputer();

            enforceOwnerRights(snapshot, packageName, Binder.getCallingUid());

            mimeTypes = CollectionUtils.emptyIfNull(mimeTypes);

            for (String mimeType : mimeTypes) {

                if (mimeType.length() > 255) {

                    throw new IllegalArgumentException("MIME type length exceeds 255 characters");

                }

            }

            final PackageStateInternal packageState = snapshot.getPackageStateInternal(packageName);

            Set<String> existingMimeTypes = packageState.getMimeGroups().get(mimeGroup);

            if (existingMimeTypes == null) {
@@ -5807,6 +5812,10 @@ public class PackageManagerService implements PackageSender, TestUtilityService 
                    && existingMimeTypes.containsAll(mimeTypes)) {

                return;

            }

            if (mimeTypes.size() > 500) {

                throw new IllegalStateException("Max limit on MIME types for MIME group "

                        + mimeGroup + " exceeded for package " + packageName);

            }



            ArraySet<String> mimeTypesSet = new ArraySet<>(mimeTypes);

            commitPackageStateMutation(null, packageName, packageStateWrite -> {

services/core/java/com/android/server/pm/pkg/parsing/ParsingPackageImpl.java

+3 −0
Original line number Diff line number Diff line
@@ -1856,6 +1856,9 @@ public class ParsingPackageImpl implements ParsingPackage, ParsingPackageHidden, 
        for (int i = component.getIntents().size() - 1; i >= 0; i--) {

            IntentFilter filter = component.getIntents().get(i).getIntentFilter();

            for (int groupIndex = filter.countMimeGroups() - 1; groupIndex >= 0; groupIndex--) {

                if (mimeGroups != null && mimeGroups.size() > 500) {

                    throw new IllegalStateException("Max limit on number of MIME Groups reached");

                }

                mimeGroups = ArrayUtils.add(mimeGroups, filter.getMimeGroup(groupIndex));

            }

        }