Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 226f36d2 authored by Jordan Demeulenaere's avatar Jordan Demeulenaere
Browse files

Enable the new footer actions for everyone 

This CL enables the new implementation of the footer actions for
everyone. Before this CL, this flag was enabled in teamfood on QPR1
builds starting from TQ1A.220827.001 [1].

Code of the old implementation will be removed in a few weeks, once
the new implementation has soaked in a bit.

[1] https://android-build.googleplex.com/builds/where-is-my-cl/search/I838318277693d4c7b0c0c6e53df9e16ff1572091

Test: Manual
Bug: 242040009
Change-Id: If0305c70dcce3a8004c29e42f4d3188ce74dfa6a
parent 9fefe95b

packages/SystemUI/res-keyguard/layout/footer_actions.xml

+2 −2
Original line number Diff line number Diff line
@@ -61,7 +61,7 @@ 
        </com.android.systemui.statusbar.phone.MultiUserSwitch>



        <com.android.systemui.statusbar.AlphaOptimizedFrameLayout

            android:id="@+id/settings_button_container"

            android:id="@id/settings_button_container"

            android:layout_width="@dimen/qs_footer_action_button_size"

            android:layout_height="@dimen/qs_footer_action_button_size"

            android:background="@drawable/qs_footer_action_circle"
@@ -85,7 +85,7 @@ 
        </com.android.systemui.statusbar.AlphaOptimizedFrameLayout>



        <com.android.systemui.statusbar.AlphaOptimizedImageView

            android:id="@+id/pm_lite"

            android:id="@id/pm_lite"

            android:layout_width="@dimen/qs_footer_action_button_size"

            android:layout_height="@dimen/qs_footer_action_button_size"

            android:background="@drawable/qs_footer_action_circle_color"

packages/SystemUI/res/values/ids.xml

+5 −0
Original line number Diff line number Diff line
@@ -185,5 +185,10 @@ 
    <item type="id" name="face_scanning_anim"/>



    <item type="id" name="qqs_tile_layout"/>



    <!-- The buttons in the Quick Settings footer actions.-->

    <item type="id" name="settings_button_container"/>

    <item type="id" name="pm_lite"/>



</resources>

packages/SystemUI/src/com/android/systemui/flags/Flags.java

+1 −1
Original line number Diff line number Diff line
@@ -155,7 +155,7 @@ public class Flags { 
    public static final ResourceBooleanFlag FULL_SCREEN_USER_SWITCHER =

            new ResourceBooleanFlag(506, R.bool.config_enableFullscreenUserSwitcher);



    public static final UnreleasedFlag NEW_FOOTER_ACTIONS = new UnreleasedFlag(507, true);

    public static final ReleasedFlag NEW_FOOTER_ACTIONS = new ReleasedFlag(507);



    /***************************************/

    // 600- status bar

packages/SystemUI/src/com/android/systemui/qs/footer/ui/binder/FooterActionsViewBinder.kt

+1 −0
Original line number Diff line number Diff line
@@ -222,6 +222,7 @@ object FooterActionsViewBinder { 


    private fun bindButton(button: IconButtonViewHolder, model: FooterActionsButtonViewModel?) {

        val buttonView = button.view

        buttonView.id = model?.id ?: View.NO_ID

        buttonView.isVisible = model != null

        if (model == null) {

            return

packages/SystemUI/src/com/android/systemui/qs/footer/ui/viewmodel/FooterActionsButtonViewModel.kt

+1 −0
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ import com.android.systemui.common.shared.model.Icon 
 * power buttons.

 */

data class FooterActionsButtonViewModel(

    val id: Int?,

    val icon: Icon,

    val iconTint: Int?,

    @DrawableRes val background: Int,