Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2197e8d6 authored by Salvador Martinez's avatar Salvador Martinez
Browse files

Added error handling to settings suggestions list 

The suggestions list in the summary page of the
settings app could sometimes cause a crash due to
an uncaught exception. Tis fixed now.

Bug: 30656840
Change-Id: If79f53e6a8c17a81653228d613797e94c473d410
(cherry picked from commit 60d92b3b)
parent 4ecc9d2d

packages/SettingsLib/src/com/android/settingslib/SuggestionParser.java

+3 −1
Original line number Original line Diff line number Diff line
@@ -28,7 +28,6 @@ import android.util.Xml; 
import android.provider.Settings;

import android.provider.Settings;

import android.accounts.Account;

import android.accounts.Account;

import android.accounts.AccountManager;

import android.accounts.AccountManager;

import android.content.ContentValues;

import android.content.pm.PackageManager;

import android.content.pm.PackageManager;

import android.content.res.Resources;

import android.content.res.Resources;

import android.view.InflateException;

import android.view.InflateException;
@@ -176,6 +175,9 @@ public class SuggestionParser { 
        } catch (PackageManager.NameNotFoundException e) {

        } catch (PackageManager.NameNotFoundException e) {

            Log.w(TAG, "Cannot find resources for " + suggestion.intent.getComponent());

            Log.w(TAG, "Cannot find resources for " + suggestion.intent.getComponent());

            return false;

            return false;

        } catch (Resources.NotFoundException e) {

            Log.w(TAG, "Cannot find resources for " + suggestion.intent.getComponent(), e);

            return false;

        }

        }

    }

    }