Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 212854ee authored by Daniel Norman's avatar Daniel Norman
Browse files

Use TYPE_ACCESSIBILITY_MAGNIFICATION_OVERLAY for windowless window mag. 

TalkBack currently is unable to swipe-to-move the focus off of
TYPE_ACCESSIBILITY_OVERLAY windows, including this mag window or any
other window of that type. See b/335440685.

It has no problems using TYPE_ACCESSIBILITY_MAGNIFICATION_OVERLAY (the
old type for this window, before windowless fix) so this change reverts
to that type until b/335440685 is resolved.

Fix: 327079186
Test: Use TalkBack to focus on the windowless window mag window. Then
      swipe left/right and observe focus is moved to another UI element.
Flag: ACONFIG com.android.systemui.create_windowless_window_magnifier TEAMFOOD
Change-Id: I7dcc1ad0e702fc1d8edcce333a9aab93deb51428
parent 4487bc7f

packages/SystemUI/src/com/android/systemui/accessibility/TEST_MAPPING

+5 −0
Original line number Diff line number Diff line
@@ -20,5 +20,10 @@ 
        }

      ]

    }

  ],

  "postsubmit": [

    {

      "name": "CtsAccessibilityServiceTestCases"

    }

  ]

}

packages/SystemUI/src/com/android/systemui/accessibility/WindowMagnificationController.java

+3 −3
Original line number Diff line number Diff line
@@ -726,11 +726,11 @@ class WindowMagnificationController implements View.OnTouchListener, SurfaceHold 
        int windowWidth = mMagnificationFrame.width() + 2 * mMirrorSurfaceMargin;

        int windowHeight = mMagnificationFrame.height() + 2 * mMirrorSurfaceMargin;



        // TODO delete TYPE_ACCESSIBILITY_MAGNIFICATION_OVERLAY, it shouldn't be needed anymore



        // TODO: b/335440685 - Move to TYPE_ACCESSIBILITY_OVERLAY after the issues with

        // that type preventing swipe to navigate are resolved.

        LayoutParams params = new LayoutParams(

                windowWidth, windowHeight,

                LayoutParams.TYPE_ACCESSIBILITY_OVERLAY,

                LayoutParams.TYPE_ACCESSIBILITY_MAGNIFICATION_OVERLAY,

                LayoutParams.FLAG_NOT_TOUCH_MODAL

                        | LayoutParams.FLAG_NOT_FOCUSABLE,

                PixelFormat.TRANSPARENT);