Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 203fdae0 authored by Valter Strods's avatar Valter Strods Committed by Gerrit Code Review
Browse files

Framework: Make the dialog divider color themeable 

The holo blue color might not be suitable for some themes. This commit
swaps out the background of all titleDivider elements to use another
resource. This has no difference from the perspective of the user of a
"stock" build but this is huge for theme users.

Thanks to Arz Bhatia for the suggestion.

Change-Id: Icb917220accac3ad38770067120a7b1be894961a
parent 9035415d

core/res/res/layout-xlarge/activity_list.xml

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ 
        <View android:id="@+id/titleDivider"

            android:layout_width="match_parent"

            android:layout_height="2dip"

            android:background="@android:color/holo_blue_light" />

            android:background="@color/dialog_title_divider" />

        <!-- If the client uses a customTitle, it will be added here. -->

    </LinearLayout>

core/res/res/layout/alert_dialog_holo.xml

+2 −2
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ 
            android:layout_width="match_parent"

            android:layout_height="2dip"

            android:visibility="gone"

            android:background="@android:color/holo_blue_light" />

            android:background="@color/dialog_title_divider" />

        <LinearLayout android:id="@+id/title_template"

            android:layout_width="match_parent"

            android:layout_height="wrap_content"
@@ -60,7 +60,7 @@ 
            android:layout_width="match_parent"

            android:layout_height="2dip"

            android:visibility="gone"

            android:background="@android:color/holo_blue_light" />

            android:background="@color/dialog_title_divider" />

        <!-- If the client uses a customTitle, it will be added here. -->

    </LinearLayout>

core/res/res/layout/dialog_custom_title_holo.xml

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ This is a custom layout for a dialog. 
    <View android:id="@+id/titleDivider"

            android:layout_width="match_parent"

            android:layout_height="2dip"

            android:background="@android:color/holo_blue_light" />

            android:background="@color/dialog_title_divider" />

    <FrameLayout

        android:layout_width="match_parent" android:layout_height="wrap_content"

        android:layout_weight="1"

core/res/res/layout/dialog_title_holo.xml

+1 −1
Original line number Diff line number Diff line
@@ -33,7 +33,7 @@ enabled. 
    <View android:id="@+id/titleDivider"

            android:layout_width="match_parent"

            android:layout_height="2dip"

            android:background="@android:color/holo_blue_light" />

            android:background="@color/dialog_title_divider" />

    <FrameLayout

        android:layout_width="match_parent" android:layout_height="wrap_content"

        android:layout_weight="1"

core/res/res/layout/dialog_title_icons_holo.xml

+1 −1
Original line number Diff line number Diff line
@@ -51,7 +51,7 @@ enabled. 
    <View android:id="@+id/titleDivider"

            android:layout_width="match_parent"

            android:layout_height="1dip"

            android:background="@android:color/holo_blue_light" />

            android:background="@color/dialog_title_divider" />



    <FrameLayout

        android:layout_width="match_parent" android:layout_height="wrap_content"