Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ffaebc4 authored by Amith Yamasani's avatar Amith Yamasani
Browse files

Fix fastscroll overlay size on WVGA by using dip. 

Move constant dimensions to resources.
parent 05b11cd7

core/java/android/widget/FastScroller.java

+8 −6
Original line number Diff line number Diff line
@@ -55,7 +55,7 @@ class FastScroller { 
    private int mThumbY;



    private RectF mOverlayPos;

    private int mOverlaySize = 104;

    private int mOverlaySize;



    private AbsListView mList;

    private boolean mScrollCompleted;
@@ -119,10 +119,10 @@ class FastScroller { 
    

    private void useThumbDrawable(Context context, Drawable drawable) {

        mThumbDrawable = drawable;

        mThumbW = (int) TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP,

                64, context.getResources().getDisplayMetrics());

        mThumbH = (int) TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP,

                52, context.getResources().getDisplayMetrics());

        mThumbW = context.getResources().getDimensionPixelSize(

                com.android.internal.R.dimen.fastscroll_thumb_width);

        mThumbH = context.getResources().getDimensionPixelSize(

                com.android.internal.R.dimen.fastscroll_thumb_height);

        mChangedBounds = true;

    }
@@ -139,6 +139,8 @@ class FastScroller { 


        getSectionsFromIndexer();



        mOverlaySize = context.getResources().getDimensionPixelSize(

                com.android.internal.R.dimen.fastscroll_overlay_size);

        mOverlayPos = new RectF();

        mScrollFade = new ScrollFade();

        mPaint = new Paint();

core/res/res/values/dimens.xml

+6 −0
Original line number Diff line number Diff line
@@ -28,4 +28,10 @@ 
    <dimen name="toast_y_offset">64dip</dimen>

    <!-- Height of the status bar -->

    <dimen name="status_bar_height">25dip</dimen>

    <!-- Size of the fastscroll hint letter -->

    <dimen name="fastscroll_overlay_size">104dp</dimen>

    <!-- Width of the fastscroll thumb -->

    <dimen name="fastscroll_thumb_width">64dp</dimen>

    <!-- Height of the fastscroll thumb -->

    <dimen name="fastscroll_thumb_height">52dp</dimen>

</resources>