Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ff59c39 authored by Riddle Hsu's avatar Riddle Hsu
Browse files

Reduce unnecessary collecting when starting on existing task 

It was added for moving a top activity to a different display:
Ib4949721eb77fb96eaa19e210f97b44163d4e4a5
It can be removed since the general display change has covered this:
Iba774557bb5ed8774d8e6b5c0bc72e8761628da6
  recycleTask > setTargetRootTaskIfNeeded
     > getOrCreateRootTask > reparent > onDisplayChanged

That avoids the additional collecting if there is no change to
the activity, e.g. launch a dialog activity on the same task.

Bug: 373410849
Flag: EXEMPT bugfix
Test: atest TransitionTests#testCollectReparentChange
Change-Id: I4d6e6d069c9e5fca3730c83bc75f312c7395052c
parent f7c4dc87

services/core/java/com/android/server/wm/ActivityStarter.java

+0 −1
Original line number Diff line number Diff line
@@ -1964,7 +1964,6 @@ class ActivityStarter { 
            if (mLastStartActivityRecord != null) {

                targetTaskTop.mLaunchSourceType = mLastStartActivityRecord.mLaunchSourceType;

            }

            targetTaskTop.mTransitionController.collect(targetTaskTop);

            recordTransientLaunchIfNeeded(targetTaskTop);

            // Recycle the target task for this launch.

            startResult =