Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1f93cec6 authored by Ibrahim Yilmaz's avatar Ibrahim Yilmaz
Browse files

[RONs] Drop BigPictureStyle from Promotable styles 


BigPictureStyle Notifications are vertically too large to accommodate on the shade and AOD. On the lock screen, these notifications will fallback to collapsed form and big picture will be shown as right icon. That's why we decided to drop bigpicture from promotable list and encourage using no style with large icon for RON usecases.

Bug: 367705002
Test: Presubmit
Flag: android.app.ui_rich_ongoing
Change-Id: I2d02667384c8960729af0727c1d146e1a98fad94
parent ab919348

core/java/android/app/Notification.java

+0 −1
Original line number Diff line number Diff line
@@ -3266,7 +3266,6 @@ public class Notification implements Parcelable 
        final Class<? extends Style> notificationStyle = getNotificationStyle();















        return notificationStyle == null













                || BigPictureStyle.class.equals(notificationStyle)















                || BigTextStyle.class.equals(notificationStyle)















                || CallStyle.class.equals(notificationStyle)















                || ProgressStyle.class.equals(notificationStyle);

































core/tests/coretests/src/android/app/NotificationTest.java



+5
−5




























Original line number
Diff line number
Diff line








@@ -371,22 +371,22 @@ public class NotificationTest {





























    @Test















    @EnableFlags(Flags.FLAG_UI_RICH_ONGOING)













    public void testHasPromotableStyle_bigPicture() {













    public void testHasPromotableStyle_bigText() {















        Notification n = new Notification.Builder(mContext, "test")















                .setSmallIcon(android.R.drawable.sym_def_app_icon)













                .setStyle(new Notification.BigPictureStyle())













                .setStyle(new Notification.BigTextStyle())















                .build();















        assertThat(n.hasPromotableStyle()).isTrue();















    }































    @Test















    @EnableFlags(Flags.FLAG_UI_RICH_ONGOING)













    public void testHasPromotableStyle_bigText() {













    public void testHasPromotableStyle_no_bigPictureStyle() {















        Notification n = new Notification.Builder(mContext, "test")















                .setSmallIcon(android.R.drawable.sym_def_app_icon)













                .setStyle(new Notification.BigTextStyle())













                .setStyle(new Notification.BigPictureStyle())















                .build();













        assertThat(n.hasPromotableStyle()).isTrue();













        assertThat(n.hasPromotableStyle()).isFalse();















    }































    @Test