Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e6d70a0 authored by Pablo Gamito's avatar Pablo Gamito
Browse files

Always collect stack traces for WTF-level ProtoLog messages 

This change ensures that a stack trace is always captured in Perfetto
traces for ProtoLog messages logged at the WTF level, regardless of
whether stack trace collection is enabled for the specific ProtoLog
group.

This will make it easier to identify the root cause of WTF log messages
in Pitot from field traces.

Flag: EXEMPT minor change
Bug: 438657912
Change-Id: I954d6ef64a5dbf391b87b12fe01f65f23943327e
parent f24b311a

core/java/com/android/internal/protolog/PerfettoProtoLogImpl.java

+2 −1
Original line number Diff line number Diff line
@@ -492,7 +492,8 @@ public abstract class PerfettoProtoLogImpl extends IProtoLogClient.Stub implemen 
        if (isProtoEnabled()) {

            long tsNanos = SystemClock.elapsedRealtimeNanos();

            final String stacktrace;

            if (mCollectStackTraceGroupCounts.getOrDefault(group.name(), 0) > 0) {

            if (logLevel == LogLevel.WTF

                    || mCollectStackTraceGroupCounts.getOrDefault(group.name(), 0) > 0) {

                stacktrace = collectStackTrace();

            } else {

                stacktrace = null;