Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e0e143c authored by Ahan Wu's avatar Ahan Wu
Browse files

Release bitmap reference right after Per85ComputeTask done its job. 

In some weird cases, AsyncTasks might not be released as soon as we
expect and the params might also be kept for a long time.

Therefore, we try to nullify the reference to the params right after
background job has been completed to avoid this kind of leakage.

Bug: 124127996
Test: run "atest android.app.cts.WallpaperManagerTest"
Test: Observe the memory usage during and after cts tests.
Change-Id: I1bb7fa827be84e1739ed47df521e687a3d7a1727
parent 05591aea

packages/SystemUI/src/com/android/systemui/glwallpaper/ImageProcessHelper.java

+3 −1
Original line number Diff line number Diff line
@@ -85,7 +85,9 @@ class ImageProcessHelper { 
            Bitmap bitmap = bitmaps[0];

            if (bitmap != null) {

                int[] histogram = processHistogram(bitmap);

                return computePercentile85(bitmap, histogram);

                Float val = computePercentile85(bitmap, histogram);

                bitmaps[0] = null;

                return val;

            }

            Log.e(TAG, "Per85ComputeTask: Can't get bitmap");

            return DEFAULT_PER85;