Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1da07de1 authored by pjgowtham's avatar pjgowtham
Browse files

UdfpsHelper: Avoid hardcoding 4095 for maximum panel brightness 

Now the array's last key is treated as maximum panel brightness
which should be the same as what's found in display devicetree
as maximum brightness for the specific panel.

Also remove the first few entries that are unused especially the
first erratic entry which sets the alpha to 255.

Change-Id: I5674d563e733a7485f75d744b0c110d551d66c1a
parent 360a0d09

packages/SystemUI/res/values/lineage_config.xml

+9 −4
Original line number Diff line number Diff line
@@ -21,11 +21,16 @@ 
    <!-- Whether to enable framework dimming for UDFPS -->

    <bool name="config_udfpsFrameworkDimming">false</bool>



    <!-- Array of brightness-alpha LUT for framework dimming -->

    <!-- Brightness-to-alpha lookup table (LUT) for UDFPS framework dimming.

         Each entry is in the format <brightness>,<alpha> where:

           - brightness = panel backlight level

           - alpha = dim layer transparency applied at that brightness

         Rules:

           • The entries should be strictly ascending by brightness.

           • First entry = <minBrightness,maxAlpha>.

           • Last entry  = <maxBrightness,minAlpha>.

    -->

    <string-array name="config_udfpsDimmingBrightnessAlphaArray" translatable="false">

          <item>0,255</item>

          <item>1,248</item>

          <item>2,242</item>

          <item>3,238</item>

          <item>4,236</item>

          <item>6,236</item>

packages/SystemUI/src/com/android/systemui/biometrics/UdfpsHelper.kt

+2 −1
Original line number Diff line number Diff line
@@ -70,6 +70,7 @@ class UdfpsHelper( 
            val (brightness, alpha) = it.split(",").map { value -> value.trim().toInt() }

            brightness to alpha

        }

    val maxPanelBrightness: Int = brightnessAlphaMap.keys.max()



    private val dimLayoutParams = WindowManager.LayoutParams(

        WindowManager.LayoutParams.TYPE_NAVIGATION_BAR_PANEL,
@@ -148,7 +149,7 @@ class UdfpsHelper( 
    // brightness_alpha_lut array from the kernel. This provides a comparable array.

    private fun brightnessToAlpha() {

        val adjustedBrightness =

            (currentBrightness.coerceIn(minBrightness, maxBrightness) * 4095).toInt()

            (currentBrightness.coerceIn(minBrightness, maxBrightness) * maxPanelBrightness).toInt()



        val targetAlpha = brightnessAlphaMap[adjustedBrightness]?.div(255.0f)

            ?: interpolateAlpha(adjustedBrightness)