Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1d13538e authored by Daniel Norman's avatar Daniel Norman
Browse files

Stops using the deprecated PackageListObserver in A11yManagerService. 

This was originally added because PackageMonitor was slow. That slowness
was resolved so PackageListObserver is now unnecessary.

There should be no observed change in behavior, but feature flagging
this as required to be safe.

Bug: 304561459
Test: atest CtsAccessibilityServiceTestCases
Change-Id: Ief37031d81b05817e285cd5cff0c8e8513c6a602
parent 7ddc262b

services/accessibility/accessibility.aconfig

+8 −1
Original line number Diff line number Diff line
@@ -41,3 +41,10 @@ flag { 
    description: "Whether to set min span of ScaleGestureDetector to zero."

    bug: "295327792"

}



flag {

    name: "deprecate_package_list_observer"

    namespace: "accessibility"

    description: "Stops using the deprecated PackageListObserver."

    bug: "304561459"

}

services/accessibility/java/com/android/server/accessibility/AccessibilityManagerService.java

+21 −21
Original line number Diff line number Diff line
@@ -841,8 +841,7 @@ public class AccessibilityManagerService extends IAccessibilityManager.Stub 
        // package changes

        monitor.register(mContext, null,  UserHandle.ALL, true);



        // Register an additional observer for new packages using PackageManagerInternal, which

        // generally notifies observers much sooner than the BroadcastReceiver-based PackageMonitor.

        if (!Flags.deprecatePackageListObserver()) {

            final PackageManagerInternal pm = LocalServices.getService(

                    PackageManagerInternal.class);

            if (pm != null) {
@@ -868,6 +867,7 @@ public class AccessibilityManagerService extends IAccessibilityManager.Stub 
                    }

                });

            }

        }



        // user change and unlock

        IntentFilter intentFilter = new IntentFilter();