Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c691f5b authored by Varun Shah's avatar Varun Shah
Browse files

Don't create unnecessary objects.

Only create a new LinkedList if one doesn't exist already for the user.

Bug: n/a
Test: atest UsageStatsTest
parent 3e2e74c1
Loading
Loading
Loading
Loading
+4 −3
Original line number Diff line number Diff line
@@ -763,11 +763,12 @@ public class UsageStatsService extends SystemService implements
                return;
            }

            final LinkedList<Event> events = mReportedEvents.get(userId, new LinkedList<>());
            events.add(event);
            if (mReportedEvents.get(userId) == null) {
            LinkedList<Event> events = mReportedEvents.get(userId);
            if (events == null) {
                events = new LinkedList<>();
                mReportedEvents.put(userId, events);
            }
            events.add(event);
            if (events.size() == 1) {
                // Every time a file is persisted to disk, mReportedEvents is cleared for this user
                // so trigger a flush to disk every time the first event has been added.