Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c264ea8 authored by Mady Mellor's avatar Mady Mellor
Browse files

Fix the dot state for persisted bubbles & clean up labels 

Test: manual & treehugger - have some persistable bubbles, reboot device,
      get a new bubble, observe that persisted bubbles don't have a dot
      on them
Bug: 159260200
Change-Id: I71b07062e8221dcee2e8cc1eeed0963d38205c8e
parent c5c35fc3

packages/SystemUI/src/com/android/systemui/bubbles/Bubble.java

+1 −0
Original line number Diff line number Diff line
@@ -144,6 +144,7 @@ class Bubble implements BubbleViewProvider { 
        mDesiredHeight = desiredHeight;

        mDesiredHeightResId = desiredHeightResId;

        mTitle = title;

        mShowBubbleUpdateDot = false;

    }



    /** Used in tests when no UI is required. */

packages/SystemUI/src/com/android/systemui/bubbles/BubbleOverflowActivity.java

+4 −13
Original line number Diff line number Diff line
@@ -22,7 +22,6 @@ import static com.android.systemui.bubbles.BubbleDebugConfig.TAG_WITH_CLASS_NAME 


import android.app.Activity;

import android.content.Context;

import android.content.pm.ShortcutInfo;

import android.content.res.Configuration;

import android.content.res.Resources;

import android.content.res.TypedArray;
@@ -289,18 +288,10 @@ class BubbleOverflowAdapter extends RecyclerView.Adapter<BubbleOverflowAdapter.V 
                    }

                });



        // If the bubble was persisted, the entry is null but it should have shortcut info

        ShortcutInfo info = b.getShortcutInfo();

        if (info == null) {

            Log.d(TAG, "ShortcutInfo required to bubble but none found for " + b);

        } else {

            CharSequence label = info.getLabel();

            if (label == null) {

                vh.textView.setText(b.getAppName());

            } else {

                vh.textView.setText(label.toString());

            }

        }

        CharSequence label = b.getShortcutInfo() != null

                ? b.getShortcutInfo().getLabel()

                : b.getAppName();

        vh.textView.setText(label);

    }



    @Override