diff --git a/packages/SystemUI/res/values-sw600dp/config.xml b/packages/SystemUI/res/values-sw600dp/config.xml index c0071cb45e2127a28109778e851847367f072a9e..80628f903e7618c0a4d46acdde95a176c04fdf7e 100644 --- a/packages/SystemUI/res/values-sw600dp/config.xml +++ b/packages/SystemUI/res/values-sw600dp/config.xml @@ -35,9 +35,6 @@ 1 - - false - true diff --git a/packages/SystemUI/res/values/config.xml b/packages/SystemUI/res/values/config.xml index ad8113aed87c4599429c8238f6ba8a641055a70f..a8027238a0bf17a04577617d24194cd0fb88e092 100644 --- a/packages/SystemUI/res/values/config.xml +++ b/packages/SystemUI/res/values/config.xml @@ -587,9 +587,6 @@ when the double-press power gesture is used. Ignored if empty. --> - - true - false diff --git a/packages/SystemUI/shared/src/com/android/systemui/shared/recents/ISystemUiProxy.aidl b/packages/SystemUI/shared/src/com/android/systemui/shared/recents/ISystemUiProxy.aidl index a030bf629507e44b36c6c14a5c8575e9e51cf633..e77c650794567eada759b8c425ba3257f051af78 100644 --- a/packages/SystemUI/shared/src/com/android/systemui/shared/recents/ISystemUiProxy.aidl +++ b/packages/SystemUI/shared/src/com/android/systemui/shared/recents/ISystemUiProxy.aidl @@ -41,13 +41,6 @@ interface ISystemUiProxy { */ void onOverviewShown(boolean fromHome) = 6; - /** - * Control the {@param alpha} of the option nav bar button (back-button in 2 button mode - * and home handle & background in gestural mode). The {@param animate} is currently only - * supported for 2 button mode. - */ - void setNavBarButtonAlpha(float alpha, boolean animate) = 19; - /** * Proxies motion events from the homescreen UI to the status bar. Only called when * swipe down is detected on WORKSPACE. The sender guarantees the following order of events on diff --git a/packages/SystemUI/src/com/android/systemui/navigationbar/NavigationBar.java b/packages/SystemUI/src/com/android/systemui/navigationbar/NavigationBar.java index 75e48d2220c8866e7f7d749c77404932dbaa603c..30947e839f0aee5412985d9b63fc9600917532db 100644 --- a/packages/SystemUI/src/com/android/systemui/navigationbar/NavigationBar.java +++ b/packages/SystemUI/src/com/android/systemui/navigationbar/NavigationBar.java @@ -35,7 +35,6 @@ import static android.view.WindowManagerPolicyConstants.NAV_BAR_MODE_GESTURAL; import static com.android.internal.accessibility.common.ShortcutConstants.CHOOSER_PACKAGE_NAME; import static com.android.internal.config.sysui.SystemUiDeviceConfigFlags.HOME_BUTTON_LONG_PRESS_DURATION_MS; -import static com.android.internal.config.sysui.SystemUiDeviceConfigFlags.NAV_BAR_HANDLE_FORCE_OPAQUE; import static com.android.systemui.navigationbar.NavBarHelper.transitionMode; import static com.android.systemui.recents.OverviewProxyService.OverviewProxyListener; import static com.android.systemui.shared.recents.utilities.Utilities.isTablet; @@ -229,10 +228,7 @@ public class NavigationBar extends ViewController implements private Locale mLocale; private int mLayoutDirection; - private boolean mAllowForceNavBarHandleOpaque; - private boolean mForceNavBarHandleOpaque; private Optional mHomeButtonLongPressDurationMs; - private boolean mIsCurrentUserSetup; /** @see android.view.WindowInsetsController#setSystemBarsAppearance(int, int) */ private @Appearance int mAppearance; @@ -378,37 +374,6 @@ public class NavigationBar extends ViewController implements mAssistManagerLazy.get().startAssist(bundle); } - @Override - public void onNavBarButtonAlphaChanged(float alpha, boolean animate) { - if (!mIsCurrentUserSetup) { - // If the current user is not yet setup, then don't update any button alphas - return; - } - if (QuickStepContract.isLegacyMode(mNavBarMode)) { - // Don't allow the bar buttons to be affected by the alpha - return; - } - - ButtonDispatcher buttonDispatcher = null; - boolean forceVisible = false; - if (QuickStepContract.isGesturalMode(mNavBarMode)) { - // Disallow home handle animations when in gestural - animate = false; - forceVisible = mAllowForceNavBarHandleOpaque && mForceNavBarHandleOpaque; - buttonDispatcher = mView.getHomeHandle(); - if (getBarTransitions() != null) { - getBarTransitions().setBackgroundOverrideAlpha(alpha); - } - } else if (QuickStepContract.isSwipeUpMode(mNavBarMode)) { - buttonDispatcher = mView.getBackButton(); - } - if (buttonDispatcher != null) { - buttonDispatcher.setVisibility( - (forceVisible || alpha > 0) ? View.VISIBLE : View.INVISIBLE); - buttonDispatcher.setAlpha(forceVisible ? 1f : alpha, animate); - } - } - @Override public void onHomeRotationEnabled(boolean enabled) { mView.getRotationButtonController().setHomeRotationEnabled(enabled); @@ -456,15 +421,10 @@ public class NavigationBar extends ViewController implements new DeviceConfig.OnPropertiesChangedListener() { @Override public void onPropertiesChanged(DeviceConfig.Properties properties) { - if (properties.getKeyset().contains(NAV_BAR_HANDLE_FORCE_OPAQUE)) { - mForceNavBarHandleOpaque = properties.getBoolean( - NAV_BAR_HANDLE_FORCE_OPAQUE, /* defaultValue = */ true); - } - if (properties.getKeyset().contains(HOME_BUTTON_LONG_PRESS_DURATION_MS)) { mHomeButtonLongPressDurationMs = Optional.of( - properties.getLong(HOME_BUTTON_LONG_PRESS_DURATION_MS, 0) - ).filter(duration -> duration != 0); + properties.getLong(HOME_BUTTON_LONG_PRESS_DURATION_MS, 0)) + .filter(duration -> duration != 0); if (mView != null) { reconfigureHomeLongClick(); } @@ -472,14 +432,6 @@ public class NavigationBar extends ViewController implements } }; - private final DeviceProvisionedController.DeviceProvisionedListener mUserSetupListener = - new DeviceProvisionedController.DeviceProvisionedListener() { - @Override - public void onUserSetupChanged() { - mIsCurrentUserSetup = mDeviceProvisionedController.isCurrentUserSetup(); - } - }; - private final NotificationShadeDepthController.DepthListener mDepthListener = new NotificationShadeDepthController.DepthListener() { boolean mHasBlurs; @@ -660,12 +612,6 @@ public class NavigationBar extends ViewController implements mCommandQueue.addCallback(this); mLongPressHomeEnabled = mNavBarHelper.getLongPressHomeEnabled(); mNavBarHelper.init(); - mAllowForceNavBarHandleOpaque = mContext.getResources().getBoolean( - R.bool.allow_force_nav_bar_handle_opaque); - mForceNavBarHandleOpaque = mDeviceConfigProxy.getBoolean( - DeviceConfig.NAMESPACE_SYSTEMUI, - NAV_BAR_HANDLE_FORCE_OPAQUE, - /* defaultValue = */ true); mHomeButtonLongPressDurationMs = Optional.of(mDeviceConfigProxy.getLong( DeviceConfig.NAMESPACE_SYSTEMUI, HOME_BUTTON_LONG_PRESS_DURATION_MS, @@ -685,8 +631,6 @@ public class NavigationBar extends ViewController implements // Respect the latest disabled-flags. mCommandQueue.recomputeDisableFlags(mDisplayId, false); - mIsCurrentUserSetup = mDeviceProvisionedController.isCurrentUserSetup(); - mDeviceProvisionedController.addCallback(mUserSetupListener); mNotificationShadeDepthController.addListener(mDepthListener); } @@ -698,7 +642,6 @@ public class NavigationBar extends ViewController implements mNavBarHelper.removeNavTaskStateUpdater(mNavbarTaskbarStateUpdater); mNavBarHelper.destroy(); - mDeviceProvisionedController.removeCallback(mUserSetupListener); mNotificationShadeDepthController.removeListener(mDepthListener); mDeviceConfigProxy.removeOnPropertiesChangedListener(mOnPropertiesChangedListener); diff --git a/packages/SystemUI/src/com/android/systemui/recents/OverviewProxyService.java b/packages/SystemUI/src/com/android/systemui/recents/OverviewProxyService.java index 99a6a4d6c10f84b978b4b3fae93b92ea9bff27ff..3788ad98092f624f914a4ab567fa3f34418c59c9 100644 --- a/packages/SystemUI/src/com/android/systemui/recents/OverviewProxyService.java +++ b/packages/SystemUI/src/com/android/systemui/recents/OverviewProxyService.java @@ -175,7 +175,6 @@ public class OverviewProxyService extends CurrentUserTracker implements private boolean mBound; private boolean mIsEnabled; private int mCurrentBoundedUserId = -1; - private float mNavBarButtonAlpha; private boolean mInputFocusTransferStarted; private float mInputFocusTransferStartY; private long mInputFocusTransferStartMillis; @@ -296,12 +295,6 @@ public class OverviewProxyService extends CurrentUserTracker implements }); } - @Override - public void setNavBarButtonAlpha(float alpha, boolean animate) { - verifyCallerAndClearCallingIdentityPostMain("setNavBarButtonAlpha", () -> - notifyNavBarButtonAlphaChanged(alpha, animate)); - } - @Override public void onAssistantProgress(@FloatRange(from = 0.0, to = 1.0) float progress) { verifyCallerAndClearCallingIdentityPostMain("onAssistantProgress", () -> @@ -610,9 +603,6 @@ public class OverviewProxyService extends CurrentUserTracker implements mBackAnimation = backAnimation; mUiEventLogger = uiEventLogger; - // Assumes device always starts with back button until launcher tells it that it does not - mNavBarButtonAlpha = 1.0f; - dumpManager.registerDumpable(getClass().getSimpleName(), this); // Listen for nav bar mode changes @@ -814,7 +804,6 @@ public class OverviewProxyService extends CurrentUserTracker implements mConnectionCallbacks.add(listener); } listener.onConnectionChanged(mOverviewProxy != null); - listener.onNavBarButtonAlphaChanged(mNavBarButtonAlpha, false); } @Override @@ -844,17 +833,10 @@ public class OverviewProxyService extends CurrentUserTracker implements if (mOverviewProxy != null) { mOverviewProxy.asBinder().unlinkToDeath(mOverviewServiceDeathRcpt, 0); mOverviewProxy = null; - notifyNavBarButtonAlphaChanged(1f, false /* animate */); notifyConnectionChanged(); } } - private void notifyNavBarButtonAlphaChanged(float alpha, boolean animate) { - for (int i = mConnectionCallbacks.size() - 1; i >= 0; --i) { - mConnectionCallbacks.get(i).onNavBarButtonAlphaChanged(alpha, animate); - } - } - private void notifyHomeRotationEnabled(boolean enabled) { for (int i = mConnectionCallbacks.size() - 1; i >= 0; --i) { mConnectionCallbacks.get(i).onHomeRotationEnabled(enabled); @@ -1083,7 +1065,6 @@ public class OverviewProxyService extends CurrentUserTracker implements pw.print(" mInputFocusTransferStartMillis="); pw.println(mInputFocusTransferStartMillis); pw.print(" mWindowCornerRadius="); pw.println(mWindowCornerRadius); pw.print(" mSupportsRoundedCornersOnWindows="); pw.println(mSupportsRoundedCornersOnWindows); - pw.print(" mNavBarButtonAlpha="); pw.println(mNavBarButtonAlpha); pw.print(" mActiveNavBarRegion="); pw.println(mActiveNavBarRegion); pw.print(" mNavBarMode="); pw.println(mNavBarMode); mSysUiState.dump(pw, args); @@ -1098,8 +1079,6 @@ public class OverviewProxyService extends CurrentUserTracker implements default void onQuickScrubStarted() {} /** Notify the recents app (overview) is started by 3-button navigation. */ default void onToggleRecentApps() {} - /** Notify changes in the nav bar button alpha */ - default void onNavBarButtonAlphaChanged(float alpha, boolean animate) {} default void onHomeRotationEnabled(boolean enabled) {} default void onTaskbarStatusUpdated(boolean visible, boolean stashed) {} default void onTaskbarAutohideSuspend(boolean suspend) {}