Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1bd0d6a5 authored by Leon Scroggins's avatar Leon Scroggins
Browse files

Allow proper text editing after clicking with the trackball. 

As with the recent change to make a touch bring up the WebTextView,
so that the trackball can be used, and we get text editing goodness,
we also need to bring up the WebTextView when clicking the trackball.
Also do not call overrideUrlLoading for an input field and add a
comment.
parent 1cc2420d

core/java/android/webkit/WebView.java

+9 −1
Original line number Diff line number Diff line
@@ -4582,6 +4582,9 @@ public class WebView extends AbsoluteLayout 
                    break;

                }

                case SWITCH_TO_CLICK:

                    // The user clicked with the trackball, and did not click a

                    // second time, so perform the action of a trackball single

                    // click

                    mTouchMode = TOUCH_DONE_MODE;

                    Rect visibleRect = sendOurVisibleRect();

                    // Note that sendOurVisibleRect calls viewToContent, so the
@@ -4593,9 +4596,14 @@ public class WebView extends AbsoluteLayout 
                    mWebViewCore.sendMessage(EventHub.SET_MOVE_MOUSE,

                            cursorData());

                    playSoundEffect(SoundEffectConstants.CLICK);

                    if (!mCallbackProxy.uiOverrideUrlLoading(nativeCursorText())) {

                    boolean isTextInput = nativeCursorIsTextInput();

                    if (isTextInput || !mCallbackProxy.uiOverrideUrlLoading(

                                nativeCursorText())) {

                        mWebViewCore.sendMessage(EventHub.CLICK);

                    }

                    if (isTextInput) {

                        rebuildWebTextView();

                    }

                    break;

                case SCROLL_BY_MSG_ID:

                    setContentScrollBy(msg.arg1, msg.arg2, (Boolean) msg.obj);