Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b9a9554 authored by Mykola Kondratenko's avatar Mykola Kondratenko Committed by Steve Kondik
Browse files

hwui : fix memory leak due to duplicate in shadow cache 

New ShadowTask with the ShadowDescription key that already
exists in the shadow LruCache will leak as it is not being
added.

Fix adds check for the existing key that is common in the hwui
code but missing for the TessellationCache::precacheShadow
function.

Change-Id: I37fd5ec82f8b8da5d1ec0f2ab9fd04c5f8534367
parent 43d7b883

libs/hwui/TessellationCache.cpp

+1 −0
Original line number Diff line number Diff line
@@ -380,6 +380,7 @@ void TessellationCache::precacheShadows(const Matrix4* drawTransform, const Rect 
        const Vector3& lightCenter, float lightRadius) {

    ShadowDescription key(casterPerimeter, drawTransform);



    if (mShadowCache.get(key)) return;

    sp<ShadowTask> task = new ShadowTask(drawTransform, localClip, opaque,

            casterPerimeter, transformXY, transformZ, lightCenter, lightRadius);

    if (mShadowProcessor == NULL) {