Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b874525 authored by Sanath Kumar's avatar Sanath Kumar
Browse files

JobScheduler: Use StringBuilder for job name generation 

Improve job name generation by using StringBuilder instead of Java
string concatenation.

This change enhances readability and extensibility by using
StringBuilder for string building, makes the code easier to understand
and modify.

Bug: 354795473
Test: atest FrameworksMockingServicesTests:com.android.server.job
Test: atest CtsJobSchedulerTestCases
Flag: EXEMPT refactor
Change-Id: If7b3027918108c0508ed880f3ecdb5415b882315
parent 889c2c74

apex/jobscheduler/service/java/com/android/server/job/controllers/JobStatus.java

+10 −4
Original line number Diff line number Diff line
@@ -673,10 +673,16 @@ public final class JobStatus { 


        this.job = job;



        final String bnNamespace = namespace == null ? "" :  "@" + namespace + "@";

        this.batteryName = this.sourceTag != null

                ? bnNamespace + this.sourceTag + ":" + job.getService().getPackageName()

                : bnNamespace + job.getService().flattenToShortString();

        StringBuilder batteryName = new StringBuilder();

        if (namespace != null) {

            batteryName.append("@").append(namespace).append("@");

        }

        if (sourceTag != null) {

            batteryName.append(sourceTag).append(":").append(job.getService().getPackageName());

        } else {

            batteryName.append(job.getService().flattenToShortString());

        }

        this.batteryName = batteryName.toString();



        final String componentPackage = job.getService().getPackageName();

        mIsProxyJob = !this.sourcePackageName.equals(componentPackage);