Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ad3955a authored by Michael Wright's avatar Michael Wright
Browse files

Remove onUhandledInputEvent API. 

This callback was never used by WebView and anyone that overrides it
is going to just be broken since we never actually call into it from
the method that WebView does call. Furthermore, the WebView team has
decided that the API has too many complications to ever implement,
the most notable of which is that MotionEvents tend to come in
streams that would need to be buffered in order to detect the event
before it can be determined whether they were handled or not which
means that any uses of the API are inevitably going to be janky
experiences.

Bug: 14279909
Change-Id: I068601ce947bccacabfe55b86b06005449b65bcf
parent 8891ae1f

api/current.txt

+1 −2
Original line number Diff line number Diff line
@@ -45774,8 +45774,7 @@ package android.webkit { 
    method public void onReceivedSslError(android.webkit.WebView, android.webkit.SslErrorHandler, android.net.http.SslError);

    method public void onScaleChanged(android.webkit.WebView, float, float);

    method public deprecated void onTooManyRedirects(android.webkit.WebView, android.os.Message, android.os.Message);

    method public void onUnhandledInputEvent(android.webkit.WebView, android.view.InputEvent);

    method public deprecated void onUnhandledKeyEvent(android.webkit.WebView, android.view.KeyEvent);

    method public void onUnhandledKeyEvent(android.webkit.WebView, android.view.KeyEvent);

    method public deprecated android.webkit.WebResourceResponse shouldInterceptRequest(android.webkit.WebView, java.lang.String);

    method public android.webkit.WebResourceResponse shouldInterceptRequest(android.webkit.WebView, android.webkit.WebResourceRequest);

    method public boolean shouldOverrideKeyEvent(android.webkit.WebView, android.view.KeyEvent);

api/removed.txt

+8 −0
Original line number Diff line number Diff line
@@ -427,6 +427,14 @@ package android.view { 


}



package android.webkit {



  public class WebViewClient {

    method public void onUnhandledInputEvent(android.webkit.WebView, android.view.InputEvent);

  }



}



package android.widget {



  public class TextView extends android.view.View implements android.view.ViewTreeObserver.OnPreDrawListener {

api/system-current.txt

+1 −2
Original line number Diff line number Diff line
@@ -48853,8 +48853,7 @@ package android.webkit { 
    method public void onReceivedSslError(android.webkit.WebView, android.webkit.SslErrorHandler, android.net.http.SslError);

    method public void onScaleChanged(android.webkit.WebView, float, float);

    method public deprecated void onTooManyRedirects(android.webkit.WebView, android.os.Message, android.os.Message);

    method public void onUnhandledInputEvent(android.webkit.WebView, android.view.InputEvent);

    method public deprecated void onUnhandledKeyEvent(android.webkit.WebView, android.view.KeyEvent);

    method public void onUnhandledKeyEvent(android.webkit.WebView, android.view.KeyEvent);

    method public deprecated android.webkit.WebResourceResponse shouldInterceptRequest(android.webkit.WebView, java.lang.String);

    method public android.webkit.WebResourceResponse shouldInterceptRequest(android.webkit.WebView, android.webkit.WebResourceRequest);

    method public boolean shouldOverrideKeyEvent(android.webkit.WebView, android.view.KeyEvent);

api/system-removed.txt

+8 −0
Original line number Diff line number Diff line
@@ -425,6 +425,14 @@ package android.view { 


}



package android.webkit {



  public class WebViewClient {

    method public void onUnhandledInputEvent(android.webkit.WebView, android.view.InputEvent);

  }



}



package android.widget {



  public class TextView extends android.view.View implements android.view.ViewTreeObserver.OnPreDrawListener {

api/test-current.txt

+1 −2
Original line number Diff line number Diff line
@@ -45851,8 +45851,7 @@ package android.webkit { 
    method public void onReceivedSslError(android.webkit.WebView, android.webkit.SslErrorHandler, android.net.http.SslError);

    method public void onScaleChanged(android.webkit.WebView, float, float);

    method public deprecated void onTooManyRedirects(android.webkit.WebView, android.os.Message, android.os.Message);

    method public void onUnhandledInputEvent(android.webkit.WebView, android.view.InputEvent);

    method public deprecated void onUnhandledKeyEvent(android.webkit.WebView, android.view.KeyEvent);

    method public void onUnhandledKeyEvent(android.webkit.WebView, android.view.KeyEvent);

    method public deprecated android.webkit.WebResourceResponse shouldInterceptRequest(android.webkit.WebView, java.lang.String);

    method public android.webkit.WebResourceResponse shouldInterceptRequest(android.webkit.WebView, android.webkit.WebResourceRequest);

    method public boolean shouldOverrideKeyEvent(android.webkit.WebView, android.view.KeyEvent);