Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1abe6def authored by Yifan Hong's avatar Yifan Hong Committed by android-build-merger
Browse files

Merge "Check for nullptr when casting IBinder to IBase." 

am: 50140286

Change-Id: I4a3c320351a9afa305a40e3912cc2e968494497c
parents 2ab7bff5 50140286

core/jni/android_os_HwBinder.cpp

+7 −0
Original line number Original line Diff line number Diff line
@@ -241,7 +241,14 @@ static void JHwBinder_native_registerService( 
    using android::hidl::manager::V1_0::IServiceManager;

    using android::hidl::manager::V1_0::IServiceManager;





    sp<hardware::IBinder> binder = JHwBinder::GetNativeContext(env, thiz);

    sp<hardware::IBinder> binder = JHwBinder::GetNativeContext(env, thiz);



    sp<hidl::base::V1_0::IBase> base = hidl::base::V1_0::IHwBase::asInterface(binder);

    sp<hidl::base::V1_0::IBase> base = hidl::base::V1_0::IHwBase::asInterface(binder);

    if (base.get() == nullptr) {

        LOG(ERROR) << "IBinder object cannot be casted to the base interface.";

        signalExceptionForError(env, UNKNOWN_ERROR);

        return;

    }



    bool ok = hardware::defaultServiceManager()->add(

    bool ok = hardware::defaultServiceManager()->add(

                interfaceChain,

                interfaceChain,

                serviceName,

                serviceName,