Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1a7b19c9 authored by Oleg Blinnikov's avatar Oleg Blinnikov Committed by Automerger Merge Worker
Browse files

Merge "Keep rounded corners during activity transitions" into tm-qpr-dev am:...

Merge "Keep rounded corners during activity transitions" into tm-qpr-dev am: bce91b77 am: de167065 am: ccf1be3b

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/21989344



Change-Id: Ia230e69fafa2bb88458b4911416dec5cb3734518
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents 6baa4fec ccf1be3b
Loading
Loading
Loading
Loading
+3 −2
Original line number Diff line number Diff line
@@ -997,7 +997,8 @@ final class LetterboxUiController {

    @VisibleForTesting
    boolean shouldShowLetterboxUi(WindowState mainWindow) {
        return isSurfaceVisible(mainWindow) && mainWindow.areAppWindowBoundsLetterboxed()
        return (mActivityRecord.isInLetterboxAnimation() || isSurfaceVisible(mainWindow))
                && mainWindow.areAppWindowBoundsLetterboxed()
                // Check for FLAG_SHOW_WALLPAPER explicitly instead of using
                // WindowContainer#showWallpaper because the later will return true when this
                // activity is using blurred wallpaper for letterbox background.
@@ -1104,7 +1105,7 @@ final class LetterboxUiController {
    // for all corners for consistency and pick a minimal bottom one for consistency with a
    // taskbar rounded corners.
    int getRoundedCornersRadius(final WindowState mainWindow) {
        if (!requiresRoundedCorners(mainWindow) || mActivityRecord.isInLetterboxAnimation()) {
        if (!requiresRoundedCorners(mainWindow)) {
            return 0;
        }

+10 −0
Original line number Diff line number Diff line
@@ -459,8 +459,17 @@ public class LetterboxUiControllerTest extends WindowTestsBase {
        mainWindow.mInvGlobalScale = invGlobalScale;
        mLetterboxConfiguration.setLetterboxActivityCornersRadius(configurationRadius);

        doReturn(true).when(mActivity).isInLetterboxAnimation();
        assertEquals(expectedRadius, mController.getRoundedCornersRadius(mainWindow));

        doReturn(false).when(mActivity).isInLetterboxAnimation();
        assertEquals(expectedRadius, mController.getRoundedCornersRadius(mainWindow));

        doReturn(false).when(mainWindow).isOnScreen();
        assertEquals(0, mController.getRoundedCornersRadius(mainWindow));

        doReturn(true).when(mActivity).isInLetterboxAnimation();
        assertEquals(expectedRadius, mController.getRoundedCornersRadius(mainWindow));
    }

    @Test
@@ -495,6 +504,7 @@ public class LetterboxUiControllerTest extends WindowTestsBase {
            insets.addSource(taskbar);
        }
        doReturn(mLetterboxedPortraitTaskBounds).when(mActivity).getBounds();
        doReturn(false).when(mActivity).isInLetterboxAnimation();
        doReturn(true).when(mActivity).isVisible();
        doReturn(true).when(mActivity).isLetterboxedForFixedOrientationAndAspectRatio();
        doReturn(insets).when(mainWindow).getInsetsState();