Revert installd changes to dexopt on /cache until we figure out what is going on. (1a3ddc61) · Commits · e / os / android_frameworks_base

cmds/installd/commands.c

+3 −12

Original line number	Diff line number	Diff line
		@@ -405,7 +405,6 @@ int create_cache_path(char path[PKG_PATH_MAX], const char *src)
		char *tmp;
		int srclen;
		int dstlen;
		char dexopt_data_only[PROPERTY_VALUE_MAX];

		srclen = strlen(src);

		@@ -418,15 +417,7 @@ int create_cache_path(char path[PKG_PATH_MAX], const char *src)
		return -1;
		}

		const char *cache_path = DALVIK_CACHE_PREFIX;
		if (!strncmp(src, "/system", 7)) {
		property_get("dalvik.vm.dexopt-data-only", dexopt_data_only, "");
		if (strcmp(dexopt_data_only, "1") != 0) {
		cache_path = DALVIK_SYSTEM_CACHE_PREFIX;
		}
		}

		dstlen = srclen + strlen(cache_path) +
		dstlen = srclen + strlen(DALVIK_CACHE_PREFIX) +
		strlen(DALVIK_CACHE_POSTFIX) + 1;

		if (dstlen > PKG_PATH_MAX) {
		@@ -434,11 +425,11 @@ int create_cache_path(char path[PKG_PATH_MAX], const char *src)
		}

		sprintf(path,"%s%s%s",
		cache_path,
		DALVIK_CACHE_PREFIX,
		src + 1, /* skip the leading / */
		DALVIK_CACHE_POSTFIX);

		for(tmp = path + strlen(cache_path); *tmp; tmp++) {
		for(tmp = path + strlen(DALVIK_CACHE_PREFIX); *tmp; tmp++) {
		if (*tmp == '/') {
		*tmp = '@';
		}

+0 −1

Original line number	Diff line number	Diff line
		@@ -67,7 +67,6 @@
		#define DALVIK_CACHE_POSTFIX "/classes.dex"

		#define UPDATE_COMMANDS_DIR_PREFIX "/system/etc/updatecmds/"
		#define DALVIK_SYSTEM_CACHE_PREFIX "/cache/dalvik-cache/"

		#define PKG_NAME_MAX 128 /* largest allowed package name */
		#define PKG_PATH_MAX 256 /* max size of any path we use */