Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1a3724ec authored by Nataniel Borges's avatar Nataniel Borges
Browse files

Promote stable PIP app tests to presubmit

These flaky tests have been stable for the past week and can be promoted

Test: atest WMShellFlickerTests:com.android.wm.shell.flicker.pip
Bug: 171049720
Bug: 167521849
Change-Id: Ibd78e9d9e53a5712ca781b265b1b65c830a74c08
parent 765f55d9
Loading
Loading
Loading
Loading
+1 −19
Original line number Original line Diff line number Diff line
@@ -16,10 +16,8 @@


package com.android.wm.shell.flicker.pip
package com.android.wm.shell.flicker.pip


import android.platform.test.annotations.Postsubmit
import android.platform.test.annotations.Presubmit
import android.platform.test.annotations.Presubmit
import android.view.Surface
import android.view.Surface
import androidx.test.filters.FlakyTest
import androidx.test.filters.RequiresDevice
import androidx.test.filters.RequiresDevice
import com.android.server.wm.flicker.FlickerParametersRunnerFactory
import com.android.server.wm.flicker.FlickerParametersRunnerFactory
import com.android.server.wm.flicker.FlickerTestParameter
import com.android.server.wm.flicker.FlickerTestParameter
@@ -64,7 +62,7 @@ class EnterPipTest(testSpec: FlickerTestParameter) : PipTransition(testSpec) {
        }
        }
    }
    }


    @Postsubmit
    @Presubmit
    @Test
    @Test
    fun pipWindowBecomesVisible() {
    fun pipWindowBecomesVisible() {
        testSpec.assertWm {
        testSpec.assertWm {
@@ -74,22 +72,6 @@ class EnterPipTest(testSpec: FlickerTestParameter) : PipTransition(testSpec) {
        }
        }
    }
    }


    @FlakyTest(bugId = 140855415)
    @Test
    override fun navBarLayerIsAlwaysVisible() = super.navBarLayerIsAlwaysVisible()

    @FlakyTest(bugId = 140855415)
    @Test
    override fun navBarLayerRotatesAndScales() = super.navBarLayerRotatesAndScales()

    @FlakyTest(bugId = 140855415)
    @Test
    override fun statusBarLayerRotatesScales() = super.statusBarLayerRotatesScales()

    @FlakyTest(bugId = 140855415)
    @Test
    override fun noUncoveredRegions() = super.noUncoveredRegions()

    companion object {
    companion object {
        @Parameterized.Parameters(name = "{0}")
        @Parameterized.Parameters(name = "{0}")
        @JvmStatic
        @JvmStatic
+4 −12
Original line number Original line Diff line number Diff line
@@ -16,7 +16,7 @@


package com.android.wm.shell.flicker.pip
package com.android.wm.shell.flicker.pip


import android.platform.test.annotations.Postsubmit
import android.platform.test.annotations.Presubmit
import android.view.Surface
import android.view.Surface
import androidx.test.filters.RequiresDevice
import androidx.test.filters.RequiresDevice
import com.android.launcher3.tapl.LauncherInstrumentation
import com.android.launcher3.tapl.LauncherInstrumentation
@@ -55,19 +55,11 @@ class PipMovesInAllApps(testSpec: FlickerTestParameter) : PipTransition(testSpec
            }
            }
        }
        }


    @Postsubmit
    @Presubmit
    @Test
    override fun statusBarWindowIsAlwaysVisible() = super.statusBarWindowIsAlwaysVisible()

    @Postsubmit
    @Test
    override fun navBarWindowIsAlwaysVisible() = super.navBarWindowIsAlwaysVisible()

    @Postsubmit
    @Test
    @Test
    fun pipAlwaysVisible() = testSpec.assertWm { this.showsAppWindow(pipApp.windowName) }
    fun pipAlwaysVisible() = testSpec.assertWm { this.showsAppWindow(pipApp.windowName) }


    @Postsubmit
    @Presubmit
    @Test
    @Test
    fun pipLayerInsideDisplay() {
    fun pipLayerInsideDisplay() {
        testSpec.assertLayersStart {
        testSpec.assertLayersStart {
@@ -75,7 +67,7 @@ class PipMovesInAllApps(testSpec: FlickerTestParameter) : PipTransition(testSpec
        }
        }
    }
    }


    @Postsubmit
    @Presubmit
    @Test
    @Test
    fun pipWindowMovesUp() = testSpec.assertWmEnd {
    fun pipWindowMovesUp() = testSpec.assertWmEnd {
        val initialState = this.trace?.first()?.wmState
        val initialState = this.trace?.first()?.wmState
+4 −5
Original line number Original line Diff line number Diff line
@@ -18,7 +18,6 @@ package com.android.wm.shell.flicker.pip


import android.platform.test.annotations.Presubmit
import android.platform.test.annotations.Presubmit
import android.view.Surface
import android.view.Surface
import androidx.test.filters.FlakyTest
import androidx.test.filters.RequiresDevice
import androidx.test.filters.RequiresDevice
import com.android.server.wm.flicker.FlickerParametersRunnerFactory
import com.android.server.wm.flicker.FlickerParametersRunnerFactory
import com.android.server.wm.flicker.FlickerTestParameter
import com.android.server.wm.flicker.FlickerTestParameter
@@ -76,19 +75,19 @@ class PipRotationTest(testSpec: FlickerTestParameter) : PipTransition(testSpec)
    override fun noUncoveredRegions() = testSpec.noUncoveredRegions(testSpec.config.startRotation,
    override fun noUncoveredRegions() = testSpec.noUncoveredRegions(testSpec.config.startRotation,
        testSpec.config.endRotation, allStates = false)
        testSpec.config.endRotation, allStates = false)


    @FlakyTest(bugId = 140855415)
    @Presubmit
    @Test
    @Test
    override fun navBarLayerRotatesAndScales() =
    override fun navBarLayerRotatesAndScales() =
        testSpec.navBarLayerRotatesAndScales(testSpec.config.startRotation,
        testSpec.navBarLayerRotatesAndScales(testSpec.config.startRotation,
            testSpec.config.endRotation)
            testSpec.config.endRotation)


    @FlakyTest(bugId = 140855415)
    @Presubmit
    @Test
    @Test
    override fun statusBarLayerRotatesScales() =
    override fun statusBarLayerRotatesScales() =
        testSpec.statusBarLayerRotatesScales(testSpec.config.startRotation,
        testSpec.statusBarLayerRotatesScales(testSpec.config.startRotation,
            testSpec.config.endRotation)
            testSpec.config.endRotation)


    @FlakyTest(bugId = 140855415)
    @Presubmit
    @Test
    @Test
    fun appLayerRotates_StartingBounds() {
    fun appLayerRotates_StartingBounds() {
        testSpec.assertLayersStart {
        testSpec.assertLayersStart {
@@ -97,7 +96,7 @@ class PipRotationTest(testSpec: FlickerTestParameter) : PipTransition(testSpec)
        }
        }
    }
    }


    @FlakyTest(bugId = 140855415)
    @Presubmit
    @Test
    @Test
    fun appLayerRotates_EndingBounds() {
    fun appLayerRotates_EndingBounds() {
        testSpec.assertLayersEnd {
        testSpec.assertLayersEnd {
+1 −2
Original line number Original line Diff line number Diff line
@@ -16,7 +16,6 @@


package com.android.wm.shell.flicker.pip
package com.android.wm.shell.flicker.pip


import android.platform.test.annotations.Postsubmit
import android.platform.test.annotations.Presubmit
import android.platform.test.annotations.Presubmit
import android.view.Surface
import android.view.Surface
import androidx.test.filters.FlakyTest
import androidx.test.filters.FlakyTest
@@ -112,7 +111,7 @@ class SetRequestedOrientationWhilePinnedTest(
        }
        }
    }
    }


    @Postsubmit
    @Presubmit
    @Test
    @Test
    fun pipAlwaysVisible() = testSpec.assertWm {
    fun pipAlwaysVisible() = testSpec.assertWm {
        this.showsAppWindow(pipApp.windowName)
        this.showsAppWindow(pipApp.windowName)