Merge "Handle invalid data during job loading." into sc-dev (1a150853) · Commits · e / os / android_frameworks_base

apex/jobscheduler/service/java/com/android/server/job/JobStore.java

+15 −2

Original line number	Diff line number	Diff line
		@@ -733,6 +733,10 @@ public final class JobStore {
		}
		} catch (XmlPullParserException \| IOException e) {
		Slog.wtf(TAG, "Error jobstore xml.", e);
		} catch (Exception e) {
		// Crashing at this point would result in a boot loop, so live with a general
		// Exception for system stability's sake.
		Slog.wtf(TAG, "Unexpected exception", e);
		} finally {
		if (mPersistInfo.countAllJobsLoaded < 0) { // Only set them once.
		mPersistInfo.countAllJobsLoaded = numJobs;
		@@ -869,6 +873,9 @@ public final class JobStore {
		} catch (IOException e) {
		Slog.d(TAG, "Error I/O Exception.", e);
		return null;
		} catch (IllegalArgumentException e) {
		Slog.e(TAG, "Constraints contained invalid data", e);
		return null;
		}

		parser.next(); // Consume </constraints>
		@@ -965,8 +972,14 @@ public final class JobStore {
		return null;
		}

		PersistableBundle extras = PersistableBundle.restoreFromXml(parser);
		final PersistableBundle extras;
		try {
		extras = PersistableBundle.restoreFromXml(parser);
		jobBuilder.setExtras(extras);
		} catch (IllegalArgumentException e) {
		Slog.e(TAG, "Persisted extras contained invalid data", e);
		return null;
		}
		parser.nextTag(); // Consume </extras>

		final JobInfo builtJob;