Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 19d6d8c1 authored by Philip P. Moltmann's avatar Philip P. Moltmann
Browse files

Remove page ranges input field when not needed 

Before it was just hidden which left an empty space. As the print
options frame is already pretty high, we want to minimize the space when
possible.

Bug: 30977905
Change-Id: If48dc852b083f014194f3f8896ec021eb0f19c0c
parent 5355afde

packages/PrintSpooler/src/com/android/printspooler/ui/PrintActivity.java

+6 −6
Original line number Diff line number Diff line
@@ -1359,8 +1359,8 @@ public class PrintActivity extends Activity implements RemotePrintDocument.Updat 
        // Page range

        mPageRangeTitle = (TextView) findViewById(R.id.page_range_title);

        mPageRangeEditText = (EditText) findViewById(R.id.page_range_edittext);

        mPageRangeEditText.setVisibility(View.INVISIBLE);

        mPageRangeTitle.setVisibility(View.INVISIBLE);

        mPageRangeEditText.setVisibility(View.GONE);

        mPageRangeTitle.setVisibility(View.GONE);

        mPageRangeEditText.setOnFocusChangeListener(mSelectAllOnFocusListener);

        mPageRangeEditText.addTextChangedListener(new RangeTextWatcher());
@@ -1881,8 +1881,8 @@ public class PrintActivity extends Activity implements RemotePrintDocument.Updat 
                        }

                    } else {

                        mPageRangeEditText.setEnabled(false);

                        mPageRangeEditText.setVisibility(View.INVISIBLE);

                        mPageRangeTitle.setVisibility(View.INVISIBLE);

                        mPageRangeEditText.setVisibility(View.GONE);

                        mPageRangeTitle.setVisibility(View.GONE);

                    }

                }

            } else {
@@ -1892,8 +1892,8 @@ public class PrintActivity extends Activity implements RemotePrintDocument.Updat 
                }

                mRangeOptionsSpinner.setEnabled(false);

                mPageRangeEditText.setEnabled(false);

                mPageRangeEditText.setVisibility(View.INVISIBLE);

                mPageRangeTitle.setVisibility(View.INVISIBLE);

                mPageRangeEditText.setVisibility(View.GONE);

                mPageRangeTitle.setVisibility(View.GONE);

            }

        }