Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18422628 authored by Jeff DeCew's avatar Jeff DeCew
Browse files

Notification template redesign; part 1. 

Known issues:
* Sub-par dyson animation
* Sub-par animation of text in the title
* Notification height limits not yet adjusted
* Decorated custom view height limits not yet updated
* HUNs may need to get their own headerless template
* Messaging style notifications are not yet headerless
* Possible [de]colorization bug for grouped icons
* Some notifications still not always expandable

Bug: 163626038
Test: Manual, visual testing
Change-Id: I9e7e2fd689938a13e042c8f6319bd7d0d2252781
parent e84b4b82

config/hiddenapi-max-target-o.txt

+0 −2
Original line number Diff line number Diff line
@@ -91659,8 +91659,6 @@ Lcom/android/internal/R$dimen;->notification_expand_button_padding_top:I 
Lcom/android/internal/R$dimen;->notification_header_app_name_margin_start:I

Lcom/android/internal/R$dimen;->notification_header_background_height:I

Lcom/android/internal/R$dimen;->notification_header_expand_icon_size:I

Lcom/android/internal/R$dimen;->notification_header_height:I

Lcom/android/internal/R$dimen;->notification_header_icon_margin_end:I

Lcom/android/internal/R$dimen;->notification_header_icon_size:I

Lcom/android/internal/R$dimen;->notification_header_separating_margin:I

Lcom/android/internal/R$dimen;->notification_header_shrink_min_width:I

core/java/android/app/Notification.java

+179 −91

File changed.

Preview size limit exceeded, changes collapsed.

core/java/android/view/NotificationHeaderView.java

+26 −117

File changed.

Preview size limit exceeded, changes collapsed.

core/java/android/view/NotificationTopLineView.java

+21 −4

File changed.

Preview size limit exceeded, changes collapsed.

core/java/com/android/internal/widget/MediaNotificationView.java

+5 −3
Original line number Diff line number Diff line
@@ -98,12 +98,14 @@ public class MediaNotificationView extends FrameLayout { 
                mMainColumn.setLayoutParams(params);

                reMeasure = true;

            }

            // TODO(b/172652345): validate all this logic (especially positioning of expand button)

            // margin for the entire header line

            int headerMarginEnd = imageEndMargin;

            // margin for the header text (not including the expand button and other icons)

            int headerTextMarginEnd = size + imageEndMargin;

            if (headerTextMarginEnd != mHeader.getHeaderTextMarginEnd()) {

                mHeader.setHeaderTextMarginEnd(headerTextMarginEnd);

            int headerExtraMarginEnd = Math.max(0,

                    size + imageEndMargin - mHeader.getTopLineBaseMarginEnd());

            if (headerExtraMarginEnd != mHeader.getTopLineExtraMarginEnd()) {

                mHeader.setTopLineExtraMarginEnd(headerExtraMarginEnd);

                reMeasure = true;

            }

            params = (MarginLayoutParams) mHeader.getLayoutParams();