Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1832a9ff authored by Chandru S's avatar Chandru S
Browse files

Minor todo cleanup 

Fixes: 275795864
Test: atest BiometricSettingsRepositoryTest
Change-Id: I93ace7934090346b0b6cdb28f58ce6db06e948be
parent 2023485b

packages/SystemUI/src/com/android/systemui/biometrics/AuthController.java

+1 −1
Original line number Diff line number Diff line
@@ -1349,7 +1349,7 @@ public class AuthController implements CoreStartable, CommandQueue.Callbacks, 
        default void onEnrollmentsChanged(@Modality int modality) {}



        /**

         * Called when UDFPS enrollments have changed. This is called after boot and on changes to

         * Called when enrollments have changed. This is called after boot and on changes to

         * enrollment.

         */

        default void onEnrollmentsChanged(

packages/SystemUI/src/com/android/systemui/keyguard/data/repository/BiometricSettingsRepository.kt

+2 −7
Original line number Diff line number Diff line
@@ -212,14 +212,9 @@ constructor( 
                            userId: Int,

                            hasEnrollments: Boolean

                        ) {

                            // TODO(b/242022358), use authController.isFaceAuthEnrolled after

                            //  ag/20176811 is available.

                            if (

                                sensorBiometricType == BiometricType.FACE &&

                                    userId == selectedUserId

                            ) {

                            if (sensorBiometricType == BiometricType.FACE) {

                                trySendWithFailureLogging(

                                    hasEnrollments,

                                    authController.isFaceAuthEnrolled(selectedUserId),

                                    TAG,

                                    "Face enrollment changed"

                                )

packages/SystemUI/tests/src/com/android/systemui/keyguard/data/repository/BiometricSettingsRepositoryTest.kt

+5 −0
Original line number Diff line number Diff line
@@ -227,10 +227,14 @@ class BiometricSettingsRepositoryTest : SysuiTestCase() { 


            assertThat(faceEnrolled()).isFalse()



            whenever(authController.isFaceAuthEnrolled(ANOTHER_USER_ID)).thenReturn(true)



            enrollmentChange(FACE, ANOTHER_USER_ID, true)



            assertThat(faceEnrolled()).isFalse()



            whenever(authController.isFaceAuthEnrolled(PRIMARY_USER_ID)).thenReturn(true)



            enrollmentChange(FACE, PRIMARY_USER_ID, true)



            assertThat(faceEnrolled()).isTrue()
@@ -264,6 +268,7 @@ class BiometricSettingsRepositoryTest : SysuiTestCase() { 


            verify(authController).addCallback(authControllerCallback.capture())



            whenever(authController.isFaceAuthEnrolled(ANOTHER_USER_ID)).thenReturn(true)

            enrollmentChange(FACE, ANOTHER_USER_ID, true)



            assertThat(faceEnrolled()).isTrue()