Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1827fdcb authored by Jungshik Jang's avatar Jungshik Jang
Browse files

Do no send <Feature Abort> as response of <Feature Abort> 

Cec service replies <Feature Abort> back to original device
if incoming message is not handled by any of feature action or device.
It's applied to <Feature Abort> message itself, but it can cause
weird sideeffect of it.
This change just ignore <Feature Abort> even though it's not handled
by any of local device or feature actions.

Bug: 16359564
Change-Id: I925e89ca4db49a637dd296447c04eee1ba679c6b
parent d10b2f17

services/core/java/com/android/server/hdmi/HdmiCecController.java

+13 −8
Original line number Diff line number Diff line
@@ -506,8 +506,14 @@ final class HdmiCecController { 
                && mService.handleCecCommand(message)) {

            return;

        }

        if (message.getDestination() == Constants.ADDR_BROADCAST) {

            return;

        }

        if (message.getOpcode() == Constants.MESSAGE_FEATURE_ABORT) {

            Slog.v(TAG, "Unhandled <Feature Abort> message:" + message);

            return;

        }



        if (message.getDestination() != Constants.ADDR_BROADCAST) {

        int sourceAddress = message.getDestination();

        // Reply <Feature Abort> to initiator (source) for all requests.

        HdmiCecMessage cecMessage = HdmiCecMessageBuilder.buildFeatureAbortCommand(
@@ -515,7 +521,6 @@ final class HdmiCecController { 
                Constants.ABORT_REFUSED);

        sendCommand(cecMessage);

    }

    }



    @ServiceThreadOnly

    void sendCommand(HdmiCecMessage cecMessage) {