Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 17e11fad authored by Erik Kline's avatar Erik Kline
Browse files

Final removal of CONNECTIVITY_ACTION_IMMEDIATE. 

Since the demise of the connectivity change delay,
CONNECTIVITY_ACTION_IMMEDIATE has been sent out back to back with
CONNECTIVITY_ACTION.

Interested parties should watch for CONNECTIVITY_ACTION.

Bug: 20013379
Change-Id: I072dddf95adb3bbd17fa1f7159d4ea848ade8f19
parent d0388299

core/java/android/net/ConnectivityManager.java

+0 −10
Original line number Diff line number Diff line
@@ -97,16 +97,6 @@ public class ConnectivityManager { 
    @SdkConstant(SdkConstantType.BROADCAST_INTENT_ACTION)

    public static final String CONNECTIVITY_ACTION = "android.net.conn.CONNECTIVITY_CHANGE";



    /**

     * Identical to {@link #CONNECTIVITY_ACTION} broadcast, but sent without any

     * historic {@link Settings.Global#CONNECTIVITY_CHANGE_DELAY}.

     *

     * @hide

     */

    @SdkConstant(SdkConstantType.BROADCAST_INTENT_ACTION)

    public static final String CONNECTIVITY_ACTION_IMMEDIATE =

            "android.net.conn.CONNECTIVITY_CHANGE_IMMEDIATE";



    /**

     * The lookup key for a {@link NetworkInfo} object. Retrieve with

     * {@link android.content.Intent#getParcelableExtra(String)}.

core/res/AndroidManifest.xml

+1 −0
Original line number Diff line number Diff line
@@ -213,6 +213,7 @@ 
    <protected-broadcast android:name="android.intent.action.MEDIA_EJECT" />



    <protected-broadcast android:name="android.net.conn.CONNECTIVITY_CHANGE" />

    <!-- @deprecated.  Only {@link android.net.ConnectivityManager.CONNECTIVITY_ACTION} is sent. -->

    <protected-broadcast android:name="android.net.conn.CONNECTIVITY_CHANGE_IMMEDIATE" />

    <protected-broadcast android:name="android.net.conn.DATA_ACTIVITY_CHANGE" />

    <protected-broadcast android:name="android.net.conn.BACKGROUND_DATA_SETTING_CHANGED" />

services/core/java/com/android/server/ConnectivityService.java

+0 −5
Original line number Diff line number Diff line
@@ -18,7 +18,6 @@ package com.android.server; 


import static android.Manifest.permission.RECEIVE_DATA_ACTIVITY_CHANGE;

import static android.net.ConnectivityManager.CONNECTIVITY_ACTION;

import static android.net.ConnectivityManager.CONNECTIVITY_ACTION_IMMEDIATE;

import static android.net.ConnectivityManager.NETID_UNSET;

import static android.net.ConnectivityManager.TYPE_NONE;

import static android.net.ConnectivityManager.TYPE_VPN;
@@ -1386,7 +1385,6 @@ public class ConnectivityService extends IConnectivityManager.Stub 


    public void sendConnectedBroadcast(NetworkInfo info) {

        enforceConnectivityInternalPermission();

        sendGeneralBroadcast(info, CONNECTIVITY_ACTION_IMMEDIATE);

        sendGeneralBroadcast(info, CONNECTIVITY_ACTION);

    }
@@ -4365,9 +4363,6 @@ public class ConnectivityService extends IConnectivityManager.Stub 
            }

            intent.putExtra(ConnectivityManager.EXTRA_INET_CONDITION,

                    mDefaultInetConditionPublished);

            final Intent immediateIntent = new Intent(intent);

            immediateIntent.setAction(CONNECTIVITY_ACTION_IMMEDIATE);

            sendStickyBroadcast(immediateIntent);

            sendStickyBroadcast(intent);

            if (newDefaultAgent != null) {

                sendConnectedBroadcast(newDefaultAgent.networkInfo);