Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 17b3afcb authored by Felipe Leme's avatar Felipe Leme
Browse files

Added shadow to RemoteViews used by authentication requests. 

Also removed obsolete autofill symbols and dimensions.

Fixes: 36492836
Bug: 36569941

Test: visual verification
Test: CtsAutoFillServiceTestCases pass

Change-Id: Id8169358bf426af5d70a82fa315e92304d06c159
parent 45061584

core/res/res/values/dimens.xml

+0 −5
Original line number Diff line number Diff line
@@ -530,9 +530,4 @@ 
    <dimen name="item_touch_helper_max_drag_scroll_per_frame">20dp</dimen>

    <dimen name="item_touch_helper_swipe_escape_velocity">120dp</dimen>

    <dimen name="item_touch_helper_swipe_escape_max_velocity">800dp</dimen>



    <!-- The elevation of AutoFill fill window-->

    <dimen name="autofill_fill_elevation">4dp</dimen>

    <dimen name="autofill_fill_item_height">64dp</dimen>

    <dimen name="autofill_fill_min_margin">16dp</dimen>

</resources>

core/res/res/values/symbols.xml

+2 −3
Original line number Diff line number Diff line
@@ -2848,9 +2848,8 @@ 
  <java-symbol type="dimen" name="item_touch_helper_swipe_escape_max_velocity"/>



  <!-- com.android.server.autofill -->

  <java-symbol type="dimen" name="autofill_fill_elevation" />

  <java-symbol type="dimen" name="autofill_fill_item_height" />

  <java-symbol type="dimen" name="autofill_fill_min_margin" />

  <!-- TODO: floating_window_z temporary exposed until Autofill UI uses a ContextThemeWrapper -->

  <java-symbol type="dimen" name="floating_window_z" />

  <java-symbol type="layout" name="autofill_save"/>

  <java-symbol type="layout" name="autofill_dataset_picker"/>

  <java-symbol type="id" name="autofill" />

services/autofill/java/com/android/server/autofill/ui/FillUi.java

+2 −2
Original line number Diff line number Diff line
@@ -100,6 +100,7 @@ final class FillUi { 
            final int heightMeasureSpec = MeasureSpec.makeMeasureSpec(MeasureSpec.UNSPECIFIED, 0);

            content.measure(widthMeasureSpec, heightMeasureSpec);

            content.setOnClickListener(v -> mCallback.onResponsePicked(response));

            content.setElevation(context.getResources().getDimension(R.dimen.floating_window_z));

            mContentWidth = content.getMeasuredWidth();

            mContentHeight = content.getMeasuredHeight();
@@ -138,8 +139,7 @@ final class FillUi { 
            };



            final LayoutInflater inflater = LayoutInflater.from(context);

            mListView = (ListView) inflater.inflate(

                    com.android.internal.R.layout.autofill_dataset_picker, null);

            mListView = (ListView) inflater.inflate(R.layout.autofill_dataset_picker, null);

            mListView.setAdapter(mAdapter);

            mListView.setOnItemClickListener((adapter, view, position, id) -> {

                final ViewItem vi = mAdapter.getItem(position);