Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 17898168 authored by Suresh Koleti's avatar Suresh Koleti
Browse files

Move isServiceReady to ImsServiceProxyCompat 

-- Move isServiceReady from ImsServiceProxy to its base class
   ImsServiceProxyCompat to use in ImsManager.

Test: Manual
Bug: 63920021
Change-Id: I0e136ffe8490a3ba985bfb5992c1ff2176e610fe
parent 01c9c0e4

telephony/java/android/telephony/ims/ImsServiceProxy.java

+0 −13
Original line number Diff line number Diff line
@@ -305,19 +305,6 @@ public class ImsServiceProxy extends ImsServiceProxyCompat implements IRcsFeatur 
        mStatusCallback = c;

    }



    /**

     * @return Returns true if the ImsService is ready to take commands, false otherwise. If this

     * method returns false, it doesn't mean that the Binder connection is not available (use

     * {@link #isBinderReady()} to check that), but that the ImsService is not accepting commands

     * at this time.

     *

     * For example, for DSDS devices, only one slot can be {@link ImsFeature#STATE_READY} to take

     * commands at a time, so the other slot must stay at {@link ImsFeature#STATE_NOT_AVAILABLE}.

     */

    public boolean isBinderReady() {

        return isBinderAlive() && getFeatureStatus() == ImsFeature.STATE_READY;

    }



    @Override

    public boolean isBinderAlive() {

        return mIsAvailable && mBinder != null && mBinder.isBinderAlive();

telephony/java/android/telephony/ims/ImsServiceProxyCompat.java

+13 −0
Original line number Diff line number Diff line
@@ -171,6 +171,19 @@ public class ImsServiceProxyCompat implements IMMTelFeature { 
        return mBinder != null && mBinder.isBinderAlive();

    }



    /**

     * @return Returns true if the ImsService is ready to take commands, false otherwise. If this

     * method returns false, it doesn't mean that the Binder connection is not available (use

     * {@link #isBinderReady()} to check that), but that the ImsService is not accepting commands

     * at this time.

     *

     * For example, for DSDS devices, only one slot can be {@link ImsFeature#STATE_READY} to take

     * commands at a time, so the other slot must stay at {@link ImsFeature#STATE_NOT_AVAILABLE}.

     */

    public boolean isBinderReady() {

        return isBinderAlive() && getFeatureStatus() == ImsFeature.STATE_READY;

    }



    private IImsService getServiceInterface(IBinder b) {

        return IImsService.Stub.asInterface(b);

    }