Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 175b2be7 authored by Glenn Kasten's avatar Glenn Kasten
Browse files

Fix build warning 

warning: pointer of type 'void *' used in arithmetic
warning: enumeral and non-enumeral type in conditional expression

Change-Id: I7b8d626a636145ef648e3b5d0e77068216dd012e
parent b6ad5b14

media/libmedia/AudioEffect.cpp

+4 −4
Original line number Diff line number Diff line
@@ -202,7 +202,7 @@ bool AudioEffect::getEnabled() const 
status_t AudioEffect::setEnabled(bool enabled)

{

    if (mStatus != NO_ERROR) {

        return (mStatus == ALREADY_EXISTS) ? INVALID_OPERATION : mStatus;

        return (mStatus == ALREADY_EXISTS) ? (status_t) INVALID_OPERATION : mStatus;

    }



    status_t status = NO_ERROR;
@@ -263,7 +263,7 @@ status_t AudioEffect::command(uint32_t cmdCode, 
status_t AudioEffect::setParameter(effect_param_t *param)

{

    if (mStatus != NO_ERROR) {

        return (mStatus == ALREADY_EXISTS) ? INVALID_OPERATION : mStatus;

        return (mStatus == ALREADY_EXISTS) ? (status_t) INVALID_OPERATION : mStatus;

    }



    if (param == NULL || param->psize == 0 || param->vsize == 0) {
@@ -281,7 +281,7 @@ status_t AudioEffect::setParameter(effect_param_t *param) 
status_t AudioEffect::setParameterDeferred(effect_param_t *param)

{

    if (mStatus != NO_ERROR) {

        return (mStatus == ALREADY_EXISTS) ? INVALID_OPERATION : mStatus;

        return (mStatus == ALREADY_EXISTS) ? (status_t) INVALID_OPERATION : mStatus;

    }



    if (param == NULL || param->psize == 0 || param->vsize == 0) {
@@ -307,7 +307,7 @@ status_t AudioEffect::setParameterDeferred(effect_param_t *param) 
status_t AudioEffect::setParameterCommit()

{

    if (mStatus != NO_ERROR) {

        return (mStatus == ALREADY_EXISTS) ? INVALID_OPERATION : mStatus;

        return (mStatus == ALREADY_EXISTS) ? (status_t) INVALID_OPERATION : mStatus;

    }



    Mutex::Autolock _l(mCblk->lock);

services/audioflinger/AudioFlinger.cpp

+1 −1
Original line number Diff line number Diff line
@@ -4122,7 +4122,7 @@ void AudioFlinger::PlaybackThread::TimedTrack::releaseBuffer( 
        TimedBuffer& head = mTimedBufferQueue.editItemAt(0);



        void* start = head.buffer()->pointer();

        void* end   = head.buffer()->pointer() + head.buffer()->size();

        void* end   = (char *) head.buffer()->pointer() + head.buffer()->size();



        if ((buffer->raw >= start) && (buffer->raw <= end)) {

            head.setPosition(head.position() +