Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 16e25e6a authored by Victoria Lease's avatar Victoria Lease
Browse files

scroll relative to visibleRect in spawnContentScrollTo()

WebKit calculates its scrolling destination coordinates relative to the
visibleRect that WebCoreViewBridge provides it. That visibleRect is stored
in WebViewClassic as mScrollOffset. When a titlebar is displaying, the
coordinate conversion from content to view fails. This conversion is used
in many other places and seems to function perfectly fine for them, so I've
concluded that while it may be the wrong tool for this particular job, it is
the correct tool for many others. As a result, I've left the conversion as it
is and simply fixed the function that WebKit calls to programatically scroll
the content. This fixes all of the programmatic scrolling issues I've been
seeing with find-on-page without breaking anything else.

  Bug: 5470588

Change-Id: I50d3af4dd8a7fbd2d04bbb41e38f3e6947fbb46a
parent dbaf2cc1
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment