Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 16a1a0f9 authored by Miranda Kephart's avatar Miranda Kephart
Browse files

Add content descriptions for dismiss and preview 

Currently the dismiss button and the screenshot preview are read as
"Unlabeled" when in talkback mode. This adds content descriptions for
them so that they are described correctly.

Test: manual
Fixes: 151325418
Change-Id: I16430fe20b285c3393903a2430e6b22cca41fafb
parent 86a72111

packages/SystemUI/res/layout/global_screenshot.xml

+4 −2
Original line number Diff line number Diff line
@@ -58,13 +58,15 @@ 
        android:elevation="@dimen/screenshot_preview_elevation"

        android:visibility="gone"

        android:background="@drawable/screenshot_rounded_corners"

        android:adjustViewBounds="true"/>

        android:adjustViewBounds="true"

        android:contentDescription="@string/screenshot_preview_description"/>

    <FrameLayout

        android:id="@+id/global_screenshot_dismiss_button"

        android:layout_width="@dimen/screenshot_dismiss_button_tappable_size"

        android:layout_height="@dimen/screenshot_dismiss_button_tappable_size"

        android:elevation="7dp"

        android:visibility="gone">

        android:visibility="gone"

        android:contentDescription="@string/screenshot_dismiss_ui_description">

        <ImageView

            android:layout_width="match_parent"

            android:layout_height="match_parent"

packages/SystemUI/res/values/strings.xml

+4 −0
Original line number Diff line number Diff line
@@ -233,6 +233,10 @@ 
    <!-- Notification text displayed when we fail to take a screenshot. [CHAR LIMIT=100] -->

    <string name="screenshot_failed_to_capture_text">Taking screenshots isn\'t allowed by the app or

        your organization</string>

    <!-- Content description indicating that tapping a button will dismiss the screenshots UI [CHAR LIMIT=NONE] -->

    <string name="screenshot_dismiss_ui_description">Dismiss screenshot</string>

    <!-- Content description indicating that tapping will open an app to view/edit the screenshot. [CHAR LIMIT=NONE] -->

    <string name="screenshot_preview_description">Open screenshot</string>



    <!-- Notification title displayed for screen recording [CHAR LIMIT=50]-->

    <string name="screenrecord_name">Screen Recorder</string>