Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1637f137 authored by Piotr Wilczyński's avatar Piotr Wilczyński
Browse files

Catch exception thrown by SystemProperties.set 

Bug: 289741818
Test: Build and flash
Change-Id: I32888c9d1d0c3a0ddb7300a9c3def6f147170667
parent 81891aad

services/core/java/com/android/server/display/DisplayPowerController.java

+22 −4
Original line number Diff line number Diff line
@@ -2251,8 +2251,17 @@ final class DisplayPowerController implements AutomaticBrightnessController.Call 
            if (!reportOnly && mPowerState.getScreenState() != state

                    && readyToUpdateDisplayState()) {

                Trace.traceCounter(Trace.TRACE_TAG_POWER, "ScreenState", state);



                String propertyKey = "debug.tracing.screen_state";

                String propertyValue = String.valueOf(state);

                try {

                    // TODO(b/153319140) remove when we can get this from the above trace invocation

                SystemProperties.set("debug.tracing.screen_state", String.valueOf(state));

                    SystemProperties.set(propertyKey, propertyValue);

                } catch (RuntimeException e) {

                    Slog.e(mTag, "Failed to set a system property: key=" + propertyKey

                            + " value=" + propertyValue + " " + e.getMessage());

                }



                mPowerState.setScreenState(state);

                // Tell battery stats about the transition.

                noteScreenState(state);
@@ -2351,8 +2360,17 @@ final class DisplayPowerController implements AutomaticBrightnessController.Call 
        }

        if (mScreenBrightnessRampAnimator.animateTo(target, sdrTarget, rate)) {

            Trace.traceCounter(Trace.TRACE_TAG_POWER, "TargetScreenBrightness", (int) target);



            String propertyKey = "debug.tracing.screen_brightness";

            String propertyValue = String.valueOf(target);

            try {

                // TODO(b/153319140) remove when we can get this from the above trace invocation

            SystemProperties.set("debug.tracing.screen_brightness", String.valueOf(target));

                SystemProperties.set(propertyKey, propertyValue);

            } catch (RuntimeException e) {

                Slog.e(mTag, "Failed to set a system property: key=" + propertyKey

                        + " value=" + propertyValue + " " + e.getMessage());

            }



            noteScreenBrightness(target);

        }

    }

services/core/java/com/android/server/display/DisplayPowerController2.java

+22 −4
Original line number Diff line number Diff line
@@ -1898,8 +1898,17 @@ final class DisplayPowerController2 implements AutomaticBrightnessController.Cal 
            if (!reportOnly && mPowerState.getScreenState() != state

                    && readyToUpdateDisplayState()) {

                Trace.traceCounter(Trace.TRACE_TAG_POWER, "ScreenState", state);



                String propertyKey = "debug.tracing.screen_state";

                String propertyValue = String.valueOf(state);

                try {

                    // TODO(b/153319140) remove when we can get this from the above trace invocation

                SystemProperties.set("debug.tracing.screen_state", String.valueOf(state));

                    SystemProperties.set(propertyKey, propertyValue);

                } catch (RuntimeException e) {

                    Slog.e(mTag, "Failed to set a system property: key=" + propertyKey

                            + " value=" + propertyValue + " " + e.getMessage());

                }



                mPowerState.setScreenState(state);

                // Tell battery stats about the transition.

                noteScreenState(state);
@@ -1978,8 +1987,17 @@ final class DisplayPowerController2 implements AutomaticBrightnessController.Cal 
        }

        if (mScreenBrightnessRampAnimator.animateTo(target, sdrTarget, rate)) {

            Trace.traceCounter(Trace.TRACE_TAG_POWER, "TargetScreenBrightness", (int) target);



            String propertyKey = "debug.tracing.screen_brightness";

            String propertyValue = String.valueOf(target);

            try {

                // TODO(b/153319140) remove when we can get this from the above trace invocation

            SystemProperties.set("debug.tracing.screen_brightness", String.valueOf(target));

                SystemProperties.set(propertyKey, propertyValue);

            } catch (RuntimeException e) {

                Slog.e(mTag, "Failed to set a system property: key=" + propertyKey

                        + " value=" + propertyValue + " " + e.getMessage());

            }



            noteScreenBrightness(target);

        }

    }