Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 15ab50ec authored by Oli Lan's avatar Oli Lan Committed by Automerger Merge Worker
Browse files

Prevent non-admin users from deleting system apps. am: 6c870e15 

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17408864



Change-Id: I40bc39502ae92a42aa44a6ed89fb4079aec52048
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents 40a1fd6b 6c870e15

services/core/java/com/android/server/pm/PackageManagerService.java

+10 −0
Original line number Diff line number Diff line
@@ -18568,6 +18568,16 @@ public class PackageManagerService extends IPackageManager.Stub 
                return PackageManager.DELETE_FAILED_INTERNAL_ERROR;

            }













            if (isSystemApp(uninstalledPs)) {













                UserInfo userInfo = mUserManager.getUserInfo(userId);













                if (userInfo == null || !userInfo.isAdmin()) {













                    Slog.w(TAG, "Not removing package " + packageName













                            + " as only admin user may downgrade system apps");













                    EventLog.writeEvent(0x534e4554, "170646036", -1, packageName);













                    return PackageManager.DELETE_FAILED_USER_RESTRICTED;













                }













            }



























            disabledSystemPs = mSettings.getDisabledSystemPkgLPr(packageName);















            // Save the enabled state before we delete the package. When deleting a stub















            // application we always set the enabled state to 'disabled'.