Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 14c4f3db authored by Brad Ebinger's avatar Brad Ebinger
Browse files

Change IMS callback AIDLs to be oneway 

A bad behaving service was causing the IMS registration
callbacks to block indefinetly waiting for the callback
binder implementation in another process to finish. Since
we update the IMS registration in a loop, we were never getting
to the updates for the other processes.

This change moves the AIDL definition to oneway. Since these
are callback AIDLs, the caller doesn't need to wait
for the callbacks to return before sending the others.

Bug: 63137625
Test: Manual
Change-Id: Id39b6b70aa20bb9986bf293abe2f9e683da4252e
parent edfb7279

telephony/java/com/android/ims/internal/IImsCallSessionListener.aidl

+1 −1
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ import com.android.ims.ImsSuppServiceNotification; 
 * by having one of the methods called on the {@link IImsCallSessionListener}.

 * {@hide}

 */

interface IImsCallSessionListener {

oneway interface IImsCallSessionListener {

    /**

     * Notifies the result of the basic session operation (setup / terminate).

     */

telephony/java/com/android/ims/internal/IImsEcbmListener.aidl

+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ package com.android.ims.internal; 
 *

 * {@hide}

 */

interface IImsEcbmListener {

oneway interface IImsEcbmListener {

    /**

     * Notifies the application when the device enters Emergency Callback Mode.

     */

telephony/java/com/android/ims/internal/IImsExternalCallStateListener.aidl

+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ import com.android.ims.ImsExternalCallState; 
 *

 * {@hide}

 */

interface IImsExternalCallStateListener {

oneway interface IImsExternalCallStateListener {



    /**

     * Notifies client when Dialog Event Package update is received

telephony/java/com/android/ims/internal/IImsRegistrationListener.aidl

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ import android.net.Uri; 
 *

 * {@hide}

 */

interface IImsRegistrationListener {

oneway interface IImsRegistrationListener {

    /**

     * Notifies the application when the device is connected to the IMS network.

     *

telephony/java/com/android/ims/internal/IImsUtListener.aidl

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ import com.android.ims.ImsReasonInfo; 
/**

 * {@hide}

 */

interface IImsUtListener {

oneway interface IImsUtListener {

    /**

     * Notifies the result of the supplementary service configuration udpate.

     */