Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 14ae367c authored by Kenny Root's avatar Kenny Root
Browse files

Do not bother to remove pending installs 

Pending install list is cleared if there is an error connecting to DCS,
so don't try to remove each pending install in the loop.

Change-Id: I736114878ad92136c3b8a3ca27a1f058adaba395
parent 4ce106f5

services/java/com/android/server/pm/PackageManagerService.java

+0 −2
Original line number Original line Diff line number Diff line
@@ -523,7 +523,6 @@ public class PackageManagerService extends IPackageManager.Stub { 
                        // Something seriously wrong. Bail out

                        // Something seriously wrong. Bail out

                        Slog.e(TAG, "Cannot bind to media container service");

                        Slog.e(TAG, "Cannot bind to media container service");

                        for (HandlerParams params : mPendingInstalls) {

                        for (HandlerParams params : mPendingInstalls) {

                            mPendingInstalls.remove(0);

                            // Indicate service bind error

                            // Indicate service bind error

                            params.serviceError();

                            params.serviceError();

                        }

                        }
@@ -575,7 +574,6 @@ public class PackageManagerService extends IPackageManager.Stub { 
                        if (!connectToService()) {

                        if (!connectToService()) {

                            Slog.e(TAG, "Failed to bind to media container service");

                            Slog.e(TAG, "Failed to bind to media container service");

                            for (HandlerParams params : mPendingInstalls) {

                            for (HandlerParams params : mPendingInstalls) {

                                mPendingInstalls.remove(0);

                                // Indicate service bind error

                                // Indicate service bind error

                                params.serviceError();

                                params.serviceError();

                            }

                            }