Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 139ce67a authored by Zekan Qian's avatar Zekan Qian
Browse files

Add comment for cases of multiple from-pages. 

Bug: 244122804
Test: unit-test & local build gallery
Change-Id: I8629b2e01b0ac4322027c07e6c17ad4853d03a8a
parent b9f60293

packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/common/SettingsEntryRepository.kt

+3 −0
Original line number Diff line number Diff line
@@ -62,6 +62,9 @@ class SettingsEntryRepository(sppRepository: SettingsPageProviderRepository) { 
            if (page == null || pageWithEntryMap.containsKey(page.id)) continue

            val spp = sppRepository.getProviderOrNull(page.sppName) ?: continue

            val newEntries = spp.buildEntry(page.arguments)

            // The page id could be existed already, if there are 2+ pages go to the same one.

            // For now, override the previous ones, which means only the last from-page is kept.

            // TODO: support multiple from-pages if necessary.

            pageWithEntryMap[page.id] = SettingsPageWithEntry(

                page = page,

                entries = newEntries,