Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1391d8ee authored by John Reck's avatar John Reck
Browse files

Don't call set_buffer_count for single buffer surfaces 

Fixes: 296145618
Test: atest android.graphics.cts.HardwareRendererTest#lockHardwareCanvasSingleBuffer
Change-Id: I1513d6f484e44cb27a7683594899f99e0d802c2b
parent e234e53b

libs/hwui/renderthread/VulkanSurface.cpp

+10 −5
Original line number Diff line number Diff line
@@ -322,12 +322,17 @@ bool VulkanSurface::UpdateWindow(ANativeWindow* window, const WindowInfo& window 
        return false;

    }



    // If bufferCount == 1 then we're in shared buffer mode and we cannot actually call

    // set_buffer_count, it'll just fail.

    if (windowInfo.bufferCount > 1) {

        err = native_window_set_buffer_count(window, windowInfo.bufferCount);

        if (err != 0) {

        ALOGE("VulkanSurface::UpdateWindow() native_window_set_buffer_count(%zu) failed: %s (%d)",

            ALOGE("VulkanSurface::UpdateWindow() native_window_set_buffer_count(%zu) failed: %s "

                  "(%d)",

                  windowInfo.bufferCount, strerror(-err), err);

            return false;

        }

    }



    err = native_window_set_usage(window, windowInfo.windowUsageFlags);

    if (err != 0) {