Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1374ff99 authored by László Dávid's avatar László Dávid
Browse files

Call to equals() comparing different types (FindBugs) 

Call to HashSet<PrintServiceInfo>.equals(ArrayList<PrintServiceInfo>).
The result of this comparison will always be false.

Change-Id: Ic8cc6eab99cea4c7b3841faf6bc84c246273e8d0
parent bb0c0ab9

services/java/com/android/server/print/UserState.java

+2 −1
Original line number Diff line number Diff line
@@ -657,7 +657,8 @@ final class UserState implements PrintSpoolerCallbacks, PrintServiceCallbacks { 
            tempPrintServices.add(PrintServiceInfo.create(installedService, mContext));

        }



        if (!tempPrintServices.equals(mInstalledServices)) {

        if (tempPrintServices.size() != mInstalledServices.size()

                || !tempPrintServices.containsAll(mInstalledServices)) {

            mInstalledServices.clear();

            mInstalledServices.addAll(tempPrintServices);

            return true;