Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 133b9df9 authored by Dianne Hackborn's avatar Dianne Hackborn
Browse files

Fix issue #16013164: Externally Reported Moderate: 

AppOpsService.setMode() allows setting mode for own uid without permission

Change-Id: Ic60a10f0e95f19658c61567826dff28b657efe73
parent b6efe90b

services/core/java/com/android/server/AppOpsService.java

+5 −1
Original line number Diff line number Diff line
@@ -368,7 +368,11 @@ public class AppOpsService extends IAppOpsService.Stub { 


    @Override

    public void setMode(int code, int uid, String packageName, int mode) {

        verifyIncomingUid(uid);

        if (Binder.getCallingPid() == Process.myPid()) {

            return;

        }

        mContext.enforcePermission(android.Manifest.permission.UPDATE_APP_OPS_STATS,

                Binder.getCallingPid(), Binder.getCallingUid(), null);

        verifyIncomingOp(code);

        ArrayList<Callback> repCbs = null;

        code = AppOpsManager.opToSwitch(code);