Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13268407 authored by Andreas Miko's avatar Andreas Miko
Browse files

Remove fromScene == toScene special handling 

Test: Ran all compose tests
Bug: b/310915136
Flag: NONE
Change-Id: I5810a891e8290615853df06a45398eeb43fca20d
parent 64a85135

packages/SystemUI/compose/scene/src/com/android/compose/animation/scene/AnimateSharedAsState.kt

+1 −5
Original line number Diff line number Diff line
@@ -175,11 +175,7 @@ private fun <T> computeValue( 
    canOverflow: Boolean,

): T {

    val state = layoutImpl.state.transitionState

    if (

        state !is TransitionState.Transition ||

            state.fromScene == state.toScene ||

            !layoutImpl.isTransitionReady(state)

    ) {

    if (state !is TransitionState.Transition || !layoutImpl.isTransitionReady(state)) {

        return sharedValue.value

    }

packages/SystemUI/compose/scene/src/com/android/compose/animation/scene/AnimateToScene.kt

+3 −9
Original line number Diff line number Diff line
@@ -47,12 +47,6 @@ internal fun CoroutineScope.animateToScene( 
    when (state) {

        is TransitionState.Idle -> animate(layoutImpl, target)

        is TransitionState.Transition -> {

            if (state.toScene == state.fromScene) {

                // Same as idle.

                animate(layoutImpl, target)

                return

            }



            // A transition is currently running: first check whether `transition.toScene` or

            // `transition.fromScene` is the same as our target scene, in which case the transition

            // can be accelerated or reversed to end up in the target state.
@@ -153,13 +147,13 @@ private fun CoroutineScope.animate( 
}



private class OneOffTransition(

    override val fromScene: SceneKey,

    override val toScene: SceneKey,

    fromScene: SceneKey,

    toScene: SceneKey,

    override val currentScene: SceneKey,

    override val isInitiatedByUserInput: Boolean,

    override val isUserInputOngoing: Boolean,

    private val animatable: Animatable<Float, AnimationVector1D>,

) : TransitionState.Transition {

) : TransitionState.Transition(fromScene, toScene) {

    override val progress: Float

        get() = animatable.value

}

packages/SystemUI/compose/scene/src/com/android/compose/animation/scene/Element.kt

+2 −3
Original line number Diff line number Diff line
@@ -288,7 +288,6 @@ private fun shouldDrawElement( 
    // Always draw the element if there is no ongoing transition or if the element is not shared.

    if (

        state !is TransitionState.Transition ||

            state.fromScene == state.toScene ||

            !layoutImpl.isTransitionReady(state) ||

            state.fromScene !in element.sceneValues ||

            state.toScene !in element.sceneValues
@@ -374,7 +373,7 @@ private fun isElementOpaque( 
): Boolean {

    val state = layoutImpl.state.transitionState



    if (state !is TransitionState.Transition || state.fromScene == state.toScene) {

    if (state !is TransitionState.Transition) {

        return true

    }
@@ -611,7 +610,7 @@ private inline fun <T> computeValue( 
    val state = layoutImpl.state.transitionState



    // There is no ongoing transition.

    if (state !is TransitionState.Transition || state.fromScene == state.toScene) {

    if (state !is TransitionState.Transition) {

        // Even if this element SceneTransitionLayout is not animated, the layout itself might be

        // animated (e.g. by another parent SceneTransitionLayout), in which case this element still

        // need to participate in the layout phase.

packages/SystemUI/compose/scene/src/com/android/compose/animation/scene/MovableElement.kt

+0 −4
Original line number Diff line number Diff line
@@ -131,10 +131,6 @@ private fun shouldComposeMovableElement( 


    val fromScene = (transitionState as TransitionState.Transition).fromScene

    val toScene = transitionState.toScene

    if (fromScene == toScene) {

        check(fromScene == scene)

        return true

    }



    val fromReady = layoutImpl.isSceneReady(fromScene)

    val toReady = layoutImpl.isSceneReady(toScene)

packages/SystemUI/compose/scene/src/com/android/compose/animation/scene/ObservableTransitionState.kt

+7 −11
Original line number Diff line number Diff line
@@ -73,9 +73,6 @@ fun SceneTransitionLayoutState.observableTransitionState(): Flow<ObservableTrans 
            when (val state = transitionState) {

                is TransitionState.Idle -> ObservableTransitionState.Idle(state.currentScene)

                is TransitionState.Transition -> {

                    if (state.fromScene == state.toScene) {

                        ObservableTransitionState.Idle(state.currentScene)

                    } else {

                    ObservableTransitionState.Transition(

                        fromScene = state.fromScene,

                        toScene = state.toScene,
@@ -86,6 +83,5 @@ fun SceneTransitionLayoutState.observableTransitionState(): Flow<ObservableTrans 
                }

            }

        }

        }

        .distinctUntilChanged()

}