Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12172baa authored by Mitsuru Oshima's avatar Mitsuru Oshima
Browse files

* component can be null after destory? 

 This was causing NPE in catch block, which hides the actual exception.
parent 8eb241b8

core/java/android/app/ActivityThread.java

+4 −3
Original line number Diff line number Diff line
@@ -31,6 +31,7 @@ import android.content.pm.InstrumentationInfo; 
import android.content.pm.PackageManager;

import android.content.pm.ProviderInfo;

import android.content.pm.ServiceInfo;

import android.content.pm.PackageParser.Component;

import android.content.res.AssetManager;

import android.content.res.Configuration;

import android.content.res.Resources;
@@ -3286,10 +3287,10 @@ public final class ActivityThread { 
                throw e;

            } catch (Exception e) {

                if (!mInstrumentation.onException(r.activity, e)) {

                    ComponentName component = r.intent.getComponent();

                    String name = component == null ? "[Unknown]" : component.toShortString();

                    throw new RuntimeException(

                            "Unable to destroy activity "

                            + r.intent.getComponent().toShortString()

                            + ": " + e.toString(), e);

                            "Unable to destroy activity " + name + ": " + e.toString(), e);

                }

            }

        }