Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10e9d1d7 authored by Chris Craik's avatar Chris Craik
Browse files

Log if a view fails to fit in the drawing cache 

Large software layers won't draw if they're larger than the size of the drawing
cache, in which case this log will be triggered.

bug:7078391
Change-Id: Ib42a060b8e3b3642417df9243a086aa15b2989b1
parent fb3ec448

core/java/android/view/View.java

+7 −4
Original line number Diff line number Diff line
@@ -12537,10 +12537,13 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 
            final boolean opaque = drawingCacheBackgroundColor != 0 || isOpaque();

            final boolean use32BitCache = attachInfo != null && attachInfo.mUse32BitDrawingCache;













            if (width <= 0 || height <= 0 ||













                     // Projected bitmap size in bytes













                    (width * height * (opaque && !use32BitCache ? 2 : 4) >













                            ViewConfiguration.get(mContext).getScaledMaximumDrawingCacheSize())) {













            final int projectedBitmapSize = width * height * (opaque && !use32BitCache ? 2 : 4);













            final int drawingCacheSize =













                    ViewConfiguration.get(mContext).getScaledMaximumDrawingCacheSize();













            if (width <= 0 || height <= 0 || projectedBitmapSize > drawingCacheSize) {













                Log.w(VIEW_LOG_TAG, "View too large to fit into drawing cache, needs "













                      + projectedBitmapSize + " bytes, only "













                      + drawingCacheSize + " available");















                destroyDrawingCache();















                mCachingFailed = true;















                return;