Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10bbc0ea authored by Selim Cinek's avatar Selim Cinek
Browse files

Fixed a racecondition when creating notification headers 

Previously we were modifying the extras of a shared notification
during the notification creation, which breaks if multiple builders
are accessing the same notification. We're now passing these options
as parameters into the various functions.

Test: create low priority group / notification / observe normal behavior
Change-Id: I2aaa5632cff55a87937a2bb3f947f15555d2e897
Fixes: 117150727
parent 67d97b4b

core/java/android/app/Notification.java

+259 −217

File changed.

Preview size limit exceeded, changes collapsed.

core/tests/coretests/src/android/app/NotificationTest.java

+2 −2
Original line number Diff line number Diff line
@@ -106,9 +106,9 @@ public class NotificationTest { 
        int backgroundColor = 0xff585868;

        int initialForegroundColor = 0xff505868;

        builder.setColorPalette(backgroundColor, initialForegroundColor);

        int primaryTextColor = builder.getPrimaryTextColor();

        int primaryTextColor = builder.getPrimaryTextColor(builder.mParams);

        assertTrue(satisfiesTextContrast(primaryTextColor, backgroundColor));

        int secondaryTextColor = builder.getSecondaryTextColor();

        int secondaryTextColor = builder.getSecondaryTextColor(builder.mParams);

        assertTrue(satisfiesTextContrast(secondaryTextColor, backgroundColor));

    }