Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1061a1f1 authored by Jorge Ruesga's avatar Jorge Ruesga
Browse files

Revert "keyguard: dont show enter key when quick unlock is enabled" 

This reverts commit 921d2ec7.


"But then you're giving out whether quick unlock is enabled or not; effectively giving knowledge to someone, who picked up your device, that they can bruteforce the PIN without ever being locked out."


Effectively, this will lead to bruteforce attacks.

Change-Id: I87c1408348b009e3b2e4375b6e99e65d809de1ab
parent 921d2ec7

packages/Keyguard/src/com/android/keyguard/KeyguardPINView.java

+0 −4
Original line number Diff line number Diff line
@@ -84,10 +84,6 @@ public class KeyguardPINView extends KeyguardPinBasedInputView { 


        boolean quickUnlock = (Settings.System.getInt(getContext().getContentResolver(),

                Settings.System.LOCKSCREEN_QUICK_UNLOCK_CONTROL, 0) == 1);

        if (quickUnlock) {

            View v = findViewById(R.id.key_enter);

            v.setVisibility(View.INVISIBLE);

        }



        boolean scramblePin = (Settings.System.getInt(getContext().getContentResolver(),

                Settings.System.LOCKSCREEN_PIN_SCRAMBLE_LAYOUT, 0) == 1);