Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1011779d authored by Prabir Pradhan's avatar Prabir Pradhan
Browse files

View: Remove tooltip callbacks when detached from window 

When a View has tooltip text set, every hover event will fire a callback
to hide the tooltip after a 15 second timeout. Since the callback holds
a reference to the View, it will leak the View for that duration after
the Activity is finished or the View is removed.

Prevent this temporary leak by removing the tooltip callbacks
immediately when the View is detatched from the window.

Bug: 281473769
Test: manual, heap dump using Android Studio
Change-Id: I9044759be0feaf094aa4c140565dfa015b944bd8
parent 8d9f729a

core/java/android/view/View.java

+2 −0
Original line number Diff line number Diff line
@@ -21821,6 +21821,8 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 
        mCurrentAnimation = null;















        if ((mViewFlags & TOOLTIP) == TOOLTIP) {













            removeCallbacks(mTooltipInfo.mShowTooltipRunnable);













            removeCallbacks(mTooltipInfo.mHideTooltipRunnable);















            hideTooltip();















        }